Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Add success and failure count OTel metrics for async shard fetch #16130

Merged
merged 1 commit into from
Sep 30, 2024
Merged

[Backport 2.x] Add success and failure count OTel metrics for async shard fetch #16130

merged 1 commit into from
Sep 30, 2024

Conversation

rahulkarajgikar
Copy link
Contributor

@rahulkarajgikar rahulkarajgikar commented Sep 30, 2024 •
edited
Loading

Backport 8ddb3ee from #15976

@rahulkarajgikar rahulkarajgikar changed the title Add success and failure count OTel metrics for async shard fetch (#15… [Backport 2.x] Add success and failure count OTel metrics for async shard fetch Sep 30, 2024
@rahulkarajgikar rahulkarajgikar marked this pull request as ready for review September 30, 2024 09:21
@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for 87ad535: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov Codecov
Copy link

codecov bot commented Sep 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 71.80%. Comparing base (08c1932) to head (87ad535).
Report is 4 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ices/shards/TransportIndicesShardStoresAction.java 14.28% 6 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #16130      +/-   ##
============================================
+ Coverage     71.74%   71.80%   +0.06%     
- Complexity    64749    64799      +50     
============================================
  Files          5278     5278              
  Lines        302779   302835      +56     
  Branches      44055    44059       +4     
============================================
+ Hits         217222   217453     +231     
+ Misses        67380    67205     -175     
  Partials      18177    18177

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shwetathareja shwetathareja merged commit d5c4081 into opensearch-project:2.x Sep 30, 2024
63 checks passed
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwetathareja shwetathareja shwetathareja approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rahulkarajgikar @shwetathareja