Update Mongo/DocDB Ack Checkpoint metrics #5350
Open
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dinu John <[email protected]>
dinujoh
requested review from
sb2k16,
chenqi0805,
engechas,
san81,
srikanthjg,
graytaylor0,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
sb2k16
approved these changes
Jan 23, 2025
oeyh
approved these changes
Jan 23, 2025
| @@ -131,7 +131,7 @@ private void monitorAcknowledgment(final ExecutorService executorService, final | |||
| private void checkpoint(final String resumeToken, final long recordCount) { | |||
| LOG.debug("Perform regular checkpointing for resume token {} at record count {}", resumeToken, recordCount); | |||
| partitionCheckpoint.checkpoint(resumeToken, recordCount); | |||
| this.recordsCheckpointed.increment(recordCount); | |||
| this.recordsCheckpointed.increment(); | |||
There was a problem hiding this comment.
So this metric now means "times" checkpointed instead of "records" checkpointed?
chenqi0805
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update Mongo/DocDB Ack Checkpoint metrics to increment when checkpoint is called and not use total records check pointed so far.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.