Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Incrementally remove resources from workflow state during deprovisioning #910

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 2f52b7e from #898.

…ing (#898)

* Add method to delete a resource from the resources_created field

Signed-off-by: Daniel Widdis <[email protected]>

* Update deprovisioned resources incrementally

Signed-off-by: Daniel Widdis <[email protected]>

* Use Log4j ParameterizedMessage for string substitutions

Signed-off-by: Daniel Widdis <[email protected]>

---------

Signed-off-by: Daniel Widdis <[email protected]>
(cherry picked from commit 2f52b7e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.01%. Comparing base (0cde785) to head (ea4b8b5).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
.../transport/DeprovisionWorkflowTransportAction.java 40.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x     #910      +/-   ##
============================================
- Coverage     78.04%   78.01%   -0.03%     
- Complexity      977      982       +5     
============================================
  Files            97       97              
  Lines          4554     4576      +22     
  Branches        423      426       +3     
============================================
+ Hits           3554     3570      +16     
- Misses          823      829       +6     
  Partials        177      177              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbwiddis
Copy link
Member

dbwiddis commented Oct 9, 2024

@navneet1v So earlier I incorrectly tagged the lucene issue but these tests definitely have the lucene99 class not found error. Does opensearch-project/k-NN#2195 need to be backported to 2.x?

@navneet1v
Copy link

navneet1v commented Oct 9, 2024

Yes it needs k-NN code needs to be backported as the changes in Opensearch core is pushed to 2.x branch like few hours ago: opensearch-project/OpenSearch#16211

@dbwiddis
Copy link
Member

dbwiddis commented Oct 9, 2024

Living on the bleeding edge!

@navneet1v
Copy link

Living on the bleeding edge!

backport PR raised: opensearch-project/k-NN#2196

@dbwiddis dbwiddis merged commit d1d48b1 into 2.x Oct 9, 2024
31 checks passed
@dbwiddis dbwiddis deleted the backport/backport-898-to-2.x branch October 9, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants