-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow to verify binary installation into dashboards core #999
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #999 +/- ##
=======================================
Coverage 63.37% 63.37%
=======================================
Files 341 341
Lines 11554 11554
Branches 2243 2243
=======================================
Hits 7322 7322
Misses 3658 3658
Partials 574 574 ☔ View full report in Codecov by Sentry. |
@SuZhou-Joe @xluo-aws it seems like there is an issue that this workflow caught in main, can you check if this is expected or not:
|
Potentially coming from core actually |
Created an issue in OSD and asked for follow up: opensearch-project/OpenSearch-Dashboards#5952 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Signed-off-by: Derek Ho <[email protected]>
4a047f3
to
74b68c4
Compare
Signed-off-by: Derek Ho <[email protected]> (cherry picked from commit d516380) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Derek Ho <[email protected]> (cherry picked from commit d516380) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
I have observed some issues within other plugins of issues being only caught at run time. This is because several things can go wrong during the build process, which may not be caught in a dev setup. This adds a workflow to verify that building and installing into OSD works on every PR.
Related issues:
opensearch-project/security-dashboards-plugin#1709
opensearch-project/security-analytics-dashboards-plugin#875
opensearch-project/dashboards-observability#309
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.