Added editorial style guide checking. #620
Merged
+1,125
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes AnalysisCommit SHA: 93c1b65 API ChangesSummaryNO CHANGES ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/11507315122/artifacts/2101233351 API Coverage
|
dblock
force-pushed
the
vale
branch
5 times, most recently
from
8d9f61e
to
e22d550
Compare
Spec Test Coverage Analysis
|
This was referenced Oct 17, 2024
dblock
force-pushed
the
vale
branch
8 times, most recently
from
efba839
to
a7a7991
Compare
dblock
requested review from
harshavamsi,
sachetalva,
nhtruong,
Xtansia,
VachaShah,
Tokesh and
aabeshov
as code owners
|
@kolchfa-aws please take a look, this is ready to be merged |
dblock
force-pushed
the
vale
branch
2 times, most recently
from
87b7199
to
2cd1f8a
Compare
kolchfa-aws
approved these changes
Oct 21, 2024
|
@nhtruong care to CR when you get a chance, please? |
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
Signed-off-by: Theo N. Truong <[email protected]>
nhtruong
approved these changes
Oct 24, 2024
nhtruong
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for running Vale on specs. This gets us reviews of .yaml files being changed.
Issues Resolved
Closes #599.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.