Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation, deployment and indexing workflows #142

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

gaiksaya
Copy link
Member

Description

This PR adds below:

  1. Validation and deployment workflow to deploy nightly playgrounds to isengard accounts.
  2. Indexing workflow to index opensearch and opensearch dashboards data into the deployed cluster.
  3. Change cluster access to public

Issues Resolved

resolves #131

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@c6a5386). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #142   +/-   ##
=======================================
  Coverage        ?   83.33%           
=======================================
  Files           ?        1           
  Lines           ?       24           
  Branches        ?        4           
=======================================
  Hits            ?       20           
  Misses          ?        4           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

opensearch_url_latest=https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/${DIST_VERSION}/latest/linux/x64/tar/dist/opensearch/opensearch-${DIST_VERSION}-linux-x64.tar.gz
opensearch_dashboards_url_latest=https://ci.opensearch.org/ci/dbc/distribution-build-opensearch-dashboards/${DIST_VERSION}/latest/linux/x64/tar/dist/opensearch-dashboards/opensearch-dashboards-${DIST_VERSION}-linux-x64.tar.gz

opensearch_build_id=$(curl -w "%{url_effective}\n" -I -L -f -S $opensearch_url_latest -o /dev/null | cut -d / -f 8)
Copy link

@rishabh6788 rishabh6788 Feb 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about reading the latest dist yml file, and parsing that using yq to fetch distribution urls, build id etc?
e.g. https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/2.11.0/8649/linux/x64/tar/dist/opensearch/manifest.yml

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion. That works much better than what I implemented. Added the change.

with:
node-version: 16.x

- name: Deploy nightly playground

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am assuming if validation fails then the flow won't even reach here, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right!

Signed-off-by: Sayali Gaikawad <[email protected]>
Copy link

@rishabh6788 rishabh6788 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. Please consider fetching the distribution tar from the dist manifest as well.

Signed-off-by: Sayali Gaikawad <[email protected]>
@gaiksaya gaiksaya merged commit 2e7b72d into opensearch-project:main Feb 15, 2024
4 checks passed
@gaiksaya gaiksaya deleted the add-GHA branch February 15, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement][Nightly Playground] Add Tools stack along with child components
2 participants