Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial changes to expose an endpoint for auth failure listener get call #4641

Merged
merged 13 commits into from
Sep 5, 2024

Conversation

derek-ho
Copy link
Collaborator

@derek-ho derek-ho commented Aug 13, 2024

Description

[Describe what this change achieves]

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
    Feature
  • Why these changes are required?
    Creates API for GET/DELETE/CREATE auth failure listeners
  • What is the old behavior before changes and new behavior after changes?
    Auth failure listeners could only be modified by yaml

Issues Resolved

Fix: #4614
Is this a backport? If so, please add backport PR # and/or commits #, and remove backport-failed label from the original PR.
No

Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here
No

Testing

Added a test

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 14 lines in your changes missing coverage. Please review.

Project coverage is 65.56%. Comparing base (a1c0c7b) to head (d565320).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...y/dlic/rest/api/AuthFailureListenersApiAction.java 85.85% 8 Missing and 6 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4641      +/-   ##
==========================================
+ Coverage   65.22%   65.56%   +0.33%     
==========================================
  Files         318      319       +1     
  Lines       22327    22448     +121     
  Branches     3591     3602      +11     
==========================================
+ Hits        14562    14717     +155     
+ Misses       5967     5923      -44     
- Partials     1798     1808      +10     
Files with missing lines Coverage Δ
...rg/opensearch/security/dlic/rest/api/Endpoint.java 100.00% <100.00%> (ø)
...security/dlic/rest/api/SecurityRestApiActions.java 80.00% <ø> (ø)
.../dlic/rest/validation/RequestContentValidator.java 83.42% <100.00%> (+0.28%) ⬆️
...search/security/securityconf/impl/v7/ConfigV7.java 84.33% <100.00%> (+6.11%) ⬆️
.../opensearch/security/support/SecurityJsonNode.java 82.75% <100.00%> (+1.98%) ⬆️
...y/dlic/rest/api/AuthFailureListenersApiAction.java 85.85% <85.85%> (ø)

... and 7 files with indirect coverage changes

Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Copy link
Contributor

@shikharj05 shikharj05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, few minor comments.

@DarshitChanpura DarshitChanpura changed the title Add initial changes to expose an endpoint for auth failure listener g… Add initial changes to expose an endpoint for auth failure listener get call Aug 22, 2024
Signed-off-by: Derek Ho <[email protected]>
@DarshitChanpura DarshitChanpura merged commit d2daa98 into opensearch-project:main Sep 5, 2024
38 checks passed
@DarshitChanpura DarshitChanpura added the backport 2.x backport to 2.x branch label Sep 5, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 5, 2024
…et call (#4641)

Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Co-authored-by: Craig Perkins <[email protected]>
(cherry picked from commit d2daa98)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Create APIs to support configuration of rate limiting
4 participants