Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add OWNERS file for redhat/knative-istio-authz #1119

Merged

Conversation

Kaustubh-pande
Copy link
Contributor

@Kaustubh-pande Kaustubh-pande commented Nov 21, 2023

This is preparation for the initial release of Red Hat Openshift Serverless (knative-istio-authz chart). A chart will be added in a follow-up PR.

The users mentioned in file are Red Hatters.

users:
- githubUsername: Kaustubh-pande
- githubUsername: pierDipi
- githubUsername: rudyredhat1
- githubUsername: ReToCode
- githubUsername: mgencur

Copy link
Contributor

Thank you for submitting PR #1119 for Helm Chart Certification!

Outcome:

Failed

Detail

One or more errors were found with the pull request:

[INFO] OWNERS file changes require manual review by maintainers.

Task Insights

Here are the outcomes of tasks driving this result.

task outcome
PR Content Check failure
Run Chart Verifier skipped
Result Verification skipped
OpenShift Client Installation skipped

For information on the certification process see:

/metadata {"vendor_label": "", "chart_name": ""}

Copy link
Contributor

Thank you for submitting PR #1119 for Helm Chart Certification!

Outcome:

Failed

Detail

One or more errors were found with the pull request:

[INFO] OWNERS file changes require manual review by maintainers.

Task Insights

Here are the outcomes of tasks driving this result.

task outcome
PR Content Check failure
Run Chart Verifier skipped
Result Verification skipped
OpenShift Client Installation skipped

For information on the certification process see:

/metadata {"vendor_label": "", "chart_name": ""}

1 similar comment
Copy link
Contributor

Thank you for submitting PR #1119 for Helm Chart Certification!

Outcome:

Failed

Detail

One or more errors were found with the pull request:

[INFO] OWNERS file changes require manual review by maintainers.

Task Insights

Here are the outcomes of tasks driving this result.

task outcome
PR Content Check failure
Run Chart Verifier skipped
Result Verification skipped
OpenShift Client Installation skipped

For information on the certification process see:

/metadata {"vendor_label": "", "chart_name": ""}

@Kaustubh-pande
Copy link
Contributor Author

Hi @komish Can you please help me to fix/merge this PR?

@komish
Copy link
Collaborator

komish commented Nov 22, 2023

@Kaustubh-pande in the future, your chart name will need to have a “redhat-“ prefix, e.g. redhat-knative-istio-authz

Just want to make sure you’re aware that this requirement will come down the pipe in the future.

Copy link
Collaborator

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@komish komish merged commit 153e3cd into openshift-helm-charts:main Nov 22, 2023
@Kaustubh-pande
Copy link
Contributor Author

@Kaustubh-pande in the future, your chart name will need to have a “redhat-“ prefix, e.g. redhat-knative-istio-authz

Just want to make sure you’re aware that this requirement will come down the pipe in the future.

@komish Thanks for the information. I'm creating another PR with the redhat- prefix in the name. As this is an initial commit it is good to make it future-ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants