Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE-1.15] Remove "DELETE" from the Serving validating webhook #1103

Merged
merged 2 commits into from
Feb 4, 2025
Merged

[RELEASE-1.15] Remove "DELETE" from the Serving validating webhook #1103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f44497c
remove DELETE from serving validating webhook
skonto Jan 27, 2025
af917a7
run generate
skonto Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion config/core/webhooks/resource-validation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ webhooks:
operations:
- CREATE
- UPDATE
- DELETE
scope: "*"
resources:
- metrics
Expand Down
2 changes: 1 addition & 1 deletion openshift/ci-operator/build-image/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ RUN wget https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3 &&
RUN ./get-helm-3 --version v3.11.3 --no-sudo && helm version

RUN GOFLAGS='' go install github.com/mikefarah/yq/v3@latest
RUN GOFLAGS='' go install -tags="exclude_graphdriver_btrfs containers_image_openpgp" github.com/containers/skopeo/cmd/skopeo@v1.16.1
RUN GOFLAGS='' go install -tags="exclude_graphdriver_btrfs containers_image_openpgp" github.com/containers/skopeo/cmd/skopeo@v1.17.0

# go install creates $GOPATH/.cache with root permissions, we delete it here
# to avoid permission issues with the runtime users
Expand Down
12 changes: 12 additions & 0 deletions openshift/patches/016-remove-delete-validation-webhook.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
diff --git a/config/core/webhooks/resource-validation.yaml b/config/core/webhooks/resource-validation.yaml
index b49665420..2fdc8e2f8 100644
--- a/config/core/webhooks/resource-validation.yaml
+++ b/config/core/webhooks/resource-validation.yaml
@@ -40,7 +40,6 @@ webhooks:
operations:
- CREATE
- UPDATE
- - DELETE
scope: "*"
resources:
- metrics
1 change: 0 additions & 1 deletion openshift/release/artifacts/serving-core.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9264,7 +9264,6 @@ webhooks:
operations:
- CREATE
- UPDATE
- DELETE
scope: "*"
resources:
- metrics
Expand Down
Loading