Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-ISSUE: move etcd defragment into recert #660

Merged
merged 1 commit into from
Sep 19, 2024
Merged

NO-ISSUE: move etcd defragment into recert #660

merged 1 commit into from
Sep 19, 2024

Conversation

tsorya
Copy link
Contributor

@tsorya tsorya commented Sep 18, 2024

Background / Context

Moved defrag option into the recert rh-ecosystem-edge/recert#165

Issue / Requirement / Reason for change

Solution / Feature Overview

Implementation Details

Other Information

@openshift-ci-robot
Copy link

@tsorya: This pull request explicitly references no jira issue.

In response to this:

Background / Context

Moved defrag option into the recert rh-ecosystem-edge/recert#165

Issue / Requirement / Reason for change

Solution / Feature Overview

Implementation Details

Other Information

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 18, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 18, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tsorya
Copy link
Contributor Author

tsorya commented Sep 18, 2024

/test all

omertuc
omertuc requested changes Sep 18, 2024
View reviewed changes
lca-cli/ops/ops.go Show resolved Hide resolved
internal/recert/recert.go Show resolved Hide resolved
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 18, 2024 •
edited
Loading

@tsorya: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ibu-e2e-flow 6e543a3 link false /test ibu-e2e-flow
ci/prow/ibi-e2e-flow 6e543a3 link false /test ibi-e2e-flow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tsorya tsorya marked this pull request as ready for review September 19, 2024 14:37
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 19, 2024
@omertuc
Copy link
Collaborator

omertuc commented Sep 19, 2024

It made the binary 6MB smaller (9%), cool

@omertuc
Copy link
Collaborator

omertuc commented Sep 19, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2024
@omertuc
Copy link
Collaborator

omertuc commented Sep 19, 2024

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: omertuc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit a473a82 into openshift-kni:main Sep 19, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omertuc omertuc omertuc requested changes

@imiller0 imiller0 Awaiting requested review from imiller0

@pixelsoccupied pixelsoccupied Awaiting requested review from pixelsoccupied

Assignees

@omertuc omertuc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tsorya @openshift-ci-robot @omertuc