-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNF-15570: Add inventory collector/persistence (part 2) #384
CNF-15570: Add inventory collector/persistence (part 2) #384
Conversation
@alegacy: This pull request references CNF-15570 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
095fc49
to
da0690d
Compare
/label tide/merge-method-rebase |
This updates models and repository functions in preparation for the upcoming resource collector implementation. Signed-off-by: Allain Legacy <[email protected]>
da0690d
to
00ac495
Compare
This adds the first pass at implementing the data collector for the inventory data. This initial implementation synchronizes the resource pool, resource type, and resource objects from the ACM and creates corresponding data change event records to track when any of these objects are created or updated. A future commit will address the delete use case as well as the other objects (e.g., deployment manager). Signed-off-by: Allain Legacy <[email protected]>
62077ad
to
1e246ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Just a minor comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mlguerrero12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This adds support for persisting deployment managers to the list of objects persisted to the database. Signed-off-by: Allain Legacy <[email protected]>
This addresses an issue in the collector persistence utilities with using transactions to execute create/update of an object combined with persisting of the data change event. Signed-off-by: Allain Legacy <[email protected]>
1e246ad
to
75a50e5
Compare
/lgtm |
This is a continuation of PR #379. At @mlguerrero12 's request I have split it so that the first 3 commits are in the other PR, and the last 4 commits are in this PR. Since the first PR isn't yet merged those commits appear here as well so just ignore those and review the last 4 only.
These are relevant here: