Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNF-16211: Expose the CT and PR conditions in the provisioning API package #468

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

Missxiaoguo
Copy link
Collaborator

Move the ClusterTemplate and ProvisioningRequest condition types and reasons to the provisioning API package, so they can be used by both webhook and controller, potentially, referenced by external component if needed.

Move the ClusterTemplate and ProvisioningRequest condition types
and reasons to the provisioning API package, so they can be used
by both webhook and controller, potentially, referenced by external
component if needed.
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jan 15, 2025

@Missxiaoguo: This pull request references CNF-16211 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Move the ClusterTemplate and ProvisioningRequest condition types and reasons to the provisioning API package, so they can be used by both webhook and controller, potentially, referenced by external component if needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from donpenney and edcdavid January 15, 2025 14:00
@browsell
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2025
@irinamihai
Copy link
Collaborator

/approve

Copy link

openshift-ci bot commented Jan 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irinamihai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 31c1269 into openshift-kni:main Jan 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants