log the event with trace level and add mqtt dataflow #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold also wait for open-cluster-management-io/sdk-go#91 |
|
/assign @clyang82 @morvencao |
morvencao
reviewed
Feb 13, 2025
| @@ -26,7 +26,7 @@ var _ GRPCAuthorizer = &KubeGRPCAuthorizer{} | |||
|
|
|||
| // TokenReview validates the given token and returns the user and groups associated with it. | |||
| func (k *KubeGRPCAuthorizer) TokenReview(ctx context.Context, token string) (user string, groups []string, err error) { | |||
| klog.V(4).Infof("TokenReview: token=%s", token) | |||
| klog.V(10).Infof("TokenReview: token=%s", token) | |||
There was a problem hiding this comment.
nit: maybe we should delete this for security concern.
skeeey
force-pushed
the
log
branch
2 times, most recently
from
6b775fa to
8302d23
Compare
|
/unhold |
Signed-off-by: Wei Liu <[email protected]>
|
sdk-go will be upgraded in #260 |
|
/ok-to-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.