feat OCM-12069 | add class and resources for cluster migrations #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcolan018
reviewed
Jan 17, 2025
|
I noticed that we need to add a "locator" to associate with endpoint /clusters/{id}/migrations |
davidleerh
reviewed
Jan 17, 2025
davidleerh
reviewed
Jan 17, 2025
davidleerh
reviewed
Jan 17, 2025
davidleerh
reviewed
Jan 17, 2025
davidleerh
reviewed
Jan 17, 2025
AlexVulaj
force-pushed
the
OCM-12069_add_cluster_migrations
branch
from
5d76c0b to
bba9bb5
Compare
|
I think "ClusterMigrations" might also need to be added in https://github.com/openshift-online/ocm-api-model/blob/main/model/clusters_mgmt/v1/cluster_resource.model with the locator. |
AlexVulaj
force-pushed
the
OCM-12069_add_cluster_migrations
branch
2 times, most recently
from
b173089 to
b70a9de
Compare
AlexVulaj
force-pushed
the
OCM-12069_add_cluster_migrations
branch
from
b70a9de to
15f9e03
Compare
|
/lgtm |
AlexVulaj
commented
Jan 20, 2025
AlexVulaj
commented
Jan 20, 2025
AlexVulaj
force-pushed
the
OCM-12069_add_cluster_migrations
branch
from
ddc044a to
e5924c0
Compare
gdbranco
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add appropriate resources and classes for cluster migrations
OCM-12069
Corresponding resources/api models
endpoints: https://gitlab.cee.redhat.com/service/uhc-clusters-service/-/blob/master/cmd/clusters-service/servecmd/apiserver/routes.go?ref_type=heads#L650-657
models: https://gitlab.cee.redhat.com/service/uhc-clusters-service/-/blob/master/pkg/api/cluster_migrations.go?ref_type=heads