OCM-7800 | Define and add pagination model to cloud_provider_inquiries #950
Conversation
cgiradkar
force-pushed
the
OCM-7800-add-pagination-model
branch
4 times, most recently
from
89f6dbb
to
c2d28fc
Compare
| */ | ||
|
|
||
| // Pagination contains the data which enables pagination on the response | ||
| struct Pagination { |
There was a problem hiding this comment.
Not that big a fan of this as it is specific only for one model.
How do other models have the pagination implemented?
There was a problem hiding this comment.
BreakGlassCredentialsListRequest has implemented pagination the request struct like this: https://github.com/openshift-online/ocm-sdk-go/blob/d6662dfa3e339336e2459a413289c5b867500131/clustersmgmt/v1/break_glass_credentials_client.go#L350
I think this way it's more pluggable to any struct that needs to implement pagination on the response.
|
lgtm |
There was a problem hiding this comment.
This seems wrong. We use a *_resource.model that automatically adds pagination components using method List. You might want to follow what's being done in https://github.com/openshift-online/ocm-api-model/blob/main/model/clusters_mgmt/v1/break_glass_credentials_resource.model#L20-L62 to support this.
cgiradkar
force-pushed
the
OCM-7800-add-pagination-model
branch
from
c2d28fc
to
f392204
Compare
Signed-off-by: Chetan Giradkar <[email protected]>
cgiradkar
force-pushed
the
OCM-7800-add-pagination-model
branch
from
f392204
to
ad9b5cc
Compare
There was a problem hiding this comment.
This builds well now and generates the following files in the SDK:
clustersmgmt/v1/cloud_provider_data_client.go
clustersmgmt/v1/cloud_provider_data_resource_json.go
clustersmgmt/v1/cloud_providers_data_client.go
clustersmgmt/v1/cloud_providers_data_resource_json.go
Is there a specific endpoint in CS associated with this or does it expect the /{aws,gcp}_inquiries/* endpoints?
The original task had broader consideration, but this PR only aims to add pagination structure to |
No description provided.