Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCM-6449 | test: Change proxy prepare workflow #48

Merged
merged 1 commit into from
May 8, 2024
Merged

OCM-6449 | test: Change proxy prepare workflow #48

merged 1 commit into from
May 8, 2024

Conversation

yingzhanredhat
Copy link
Contributor

@xueli181114
Copy link
Contributor

/lgtm

ciaranRoche
ciaranRoche reviewed May 8, 2024
View reviewed changes
pkg/aws/aws_client/image.go Outdated Show resolved Hide resolved
pkg/test/vpc_client/proxy.go Outdated Show resolved Hide resolved
pkg/test/vpc_client/proxy.go Show resolved Hide resolved
pkg/test/vpc_client/proxy.go Outdated Show resolved Hide resolved
@yingzhanredhat
Copy link
Contributor Author

@ciaranRoche Fixed it. Would you help review it again?

ciaranRoche
ciaranRoche approved these changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@ciaranRoche ciaranRoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ciaranRoche ciaranRoche merged commit 37822c5 into openshift-online:main May 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xueli181114 xueli181114 xueli181114 left review comments

@ciaranRoche ciaranRoche ciaranRoche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yingzhanredhat @xueli181114 @ciaranRoche