OCM-9885 | feat: add validation for node pool custom disk size #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wkutler <[email protected]>
|
/lgtm |
gdbranco
reviewed
Aug 1, 2024
| @@ -17,6 +17,9 @@ const ( | |||
| // machinePoolRootVolumeSizeMaxAsOf414 is the maximum size of the root volume as of 4.14 | |||
| // 16 TiB - limit as of 4.14 | |||
| machinePoolRootVolumeSizeMaxAsOf414 = 16384 | |||
There was a problem hiding this comment.
Isn't that the same value?
There was a problem hiding this comment.
Oh, is there a difference from topology or is it only an OCP thing? Should we separate just to be safer?
There was a problem hiding this comment.
we just want to keep them separate in case we want to change the requirements to be different for HCP. the minimum specifically may be lower than classic but for now I'm just using the same values as classic so we can get the API changes in sooner
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for https://issues.redhat.com/browse/OCM-1027
Adds separate validation for custom root disk size for node pools. We want to keep the validation separate from classic machine pools since this validation does not require version and the min and max disk size may eventually be different in HCP from classic