Remove Fullname search parameter from status board product, application, and service. #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinaafitz
force-pushed
the
remove_fullname
branch
from
3855ce8
to
bc0b615
Compare
tinaafitz
force-pushed
the
remove_fullname
branch
from
bc0b615
to
8acb5bf
Compare
|
Hi @smcavey, Please review. :-) |
|
Is there a model version change that should be associated with these changes? |
tinaafitz
force-pushed
the
remove_fullname
branch
from
8acb5bf
to
31b3364
Compare
|
Hi @smcavey
Yes. I added a commit to update the version. :-) |
|
lgtm :) |
tinaafitz
force-pushed
the
remove_fullname
branch
2 times, most recently
from
a238274
to
849fd2c
Compare
|
Hi @tzvatot, Can you review this MR when you have time? Thank you so much. :-) |
tzvatot
requested changes
Feb 6, 2024
tzvatot
requested changes
Feb 7, 2024
CHANGES.md
Outdated
| ## 0.1.399 | ||
| - Remove `StatusBoard` `fullname` search parameter. | ||
| - Deprecate `Notify` resource. | ||
| - Update model version v0.0.352. |
There was a problem hiding this comment.
Please see example on how to document this: https://github.com/openshift-online/ocm-sdk-go/blob/main/CHANGES.md#01391
tinaafitz
force-pushed
the
remove_fullname
branch
from
4da5ed5
to
2f9fe87
Compare
tzvatot
requested changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ocm-api-model changes: openshift-online/ocm-api-model#872.