Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCM-4946: Secure Store #887

Merged
merged 11 commits into from
Jan 17, 2024
Merged

OCM-4946: Secure Store #887

merged 11 commits into from
Jan 17, 2024

Conversation

tylercreller
Copy link
Member

@tylercreller tylercreller commented Jan 12, 2024 •
edited
Loading

  • Adds secure OS storage for OCM configuration

Testing

  • WinCred: Tested on Windows 11 (introduced compression with 2500 byte limit)
  • MacOS Keychain: Tested on Sonoma 14.2.1 (Dec 2023)
  • SecretService: Tested on RHEL 9.3
  • KWallet: Tested on RHEL 9.3 w/ KDE Plasma
  • KeyCtl: Tested on RHEL 9.3
  • Pass: Tested on RHEL and MacOS
  • File: Tested on all above OS

@tylercreller tylercreller changed the title OCM-4946: Secure Store implementation OCM-4946: Secure Store Jan 12, 2024
@tylercreller tylercreller marked this pull request as draft January 12, 2024 20:11
@tylercreller tylercreller marked this pull request as ready for review January 17, 2024 16:13
@tirthct tirthct merged commit 9f56d83 into openshift-online:main Jan 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirthct tirthct tirthct approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tylercreller @tirthct