Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate keychain to use non-CGO libraries #911

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

tylercreller
Copy link
Member

@tylercreller tylercreller commented Feb 26, 2024

  • Refactors keychain keyring storage to use a non-CGO library
  • Adds tests for keychain, wincred, pass
  • Modifies PR check CI to have separate runs per platform for keyring tests

@macgregor
Copy link

for context, why do we want to use a non-CGO library?

@tylercreller
Copy link
Member Author

tylercreller commented Feb 27, 2024

for context, why do we want to use a non-CGO library?

@macgregor CGO breaks cross-compilation. Requiring CGO for our CLIs requires workarounds for cross-compilation or building darwin binaries on dedicated macOS CI runners. For ROSA this is a large amount of overhead due to their current release processes.

@cristianoveiga
Copy link
Collaborator

LGTM

@tylercreller tylercreller merged commit fbf6c59 into openshift-online:main Feb 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants