-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: synchronise to ocm-api-model 0.0.365 #935
Conversation
@@ -27,7 +27,7 @@ export PATH := $(LOCAL_BIN_PATH):$(PATH) | |||
export CGO_ENABLED=0 | |||
|
|||
# Details of the model to use: | |||
model_version:=v0.0.364 | |||
model_version:=v0.0.365 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually put this as bump MRs, and document in the CHANGES.md accordingly. See 0.1.410 as example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Lir10 are you planing to update the CHANGES.md in a followup MR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep here it is #936
fcb6d53
to
ace0977
Compare
@@ -27,7 +27,7 @@ export PATH := $(LOCAL_BIN_PATH):$(PATH) | |||
export CGO_ENABLED=0 | |||
|
|||
# Details of the model to use: | |||
model_version:=v0.0.364 | |||
model_version:=v0.0.365 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Lir10 are you planing to update the CHANGES.md in a followup MR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.