-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update workflow to remove lint as there is no support from catalog-cd tool #33
Update workflow to remove lint as there is no support from catalog-cd tool #33
Conversation
.github/workflows/test.yaml
Outdated
git clone https://github.com/tektoncd/catlin | ||
cd catlin | ||
make bin/catlin | ||
sudo cp bin/catlin /usr/local/bin | ||
catlin --help |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we removing the portion of linting using Catlin? @savitaashture
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good question!!
I did check for all the repos and i don't see anywhere we are doing linting using catalin (Not sure the reason) as well i remember @vdemeester saying that something related to catlin tool
So just removed from Openshift as well and thought to bring this point in the ecosystem discussion call to have a consistent linting across all the repos for yamls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah but I remember @vdemeester told that we require to run some form of linting on the results of the helm template and we used Catlin as it was upstream. This linting was added because there was a JIRA issue that required that our tasks (or the tasks in ecosystem catalog) should contain Red Hat supported images only and we decided to ensure this by making some changes to the portion of linting only. @savitaashture
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I think @vdemeester can provide a better context to this than me@savitaashture
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed only catalog-cd tool part as there is no lint and kept catalin lint as it is
Verified linting execution here https://github.com/savitaashture/task-openshift/actions/runs/8564598061/job/23471378385
.github/workflows/test.yaml
Outdated
# run Catlin linting | ||
- name: Run Catlin linting | ||
run: | | ||
set -Eeu | ||
helm template task-oc . > task-oc.yaml | ||
cat task-oc.yaml | ||
catlin validate task-oc.yaml || true | ||
helm template task-tkn . > task-tkn.yaml | ||
cat task-tkn.yaml | ||
catlin validate task-tkn.yaml || true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we require any kind of linting for the YAML files? @savitaashture
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same ans as abve
This makes sense to me, the lint job has been failing since Jan end as I see it. |
@Aneesh-M-Bhat The failure of CI on all pushed commit is because we don't have serverless installed for Kind after adding
|
@Aneesh-M-Bhat created issue : #34 |
6033ebb
to
dbc25a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: savitaashture, Senjuti256 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
39aaef1
into
openshift-pipelines:main
Update the workflow as there is no lint command available in catalog-cd tool