-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cluster post config #662
base: cluster-post-config
Are you sure you want to change the base?
Cluster post config #662
Conversation
b0583ba
to
3e796df
Compare
/assign @qiliRedHat |
Jenkinsfile
Outdated
@@ -23,6 +23,7 @@ pipeline { | |||
''' | |||
) | |||
booleanParam(name:'INFRA_NODES', defaultValue:true, description:'If set to true, infra nodes machineset will be created, and options listed below will be used') | |||
booleanParam(name:'IF_CREATE_WORKLOAD_NODE', defaultValue:true, description:'If set to true, creating workload machineset and nodes') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liqcui We can make the default value as false, because no workloads needs the workload node now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And in https://github.com/openshift-qe/ocp-qe-perfscale-ci/blob/cluster-workers-scaling/Jenkinsfile, I think we don't need the env vars related to the workload nodes too. I think you can remove them too.
@liqcui In Jenkins, https://github.com/openshift-qe/ocp-qe-perfscale-ci/blob/cluster-workers-scaling/Jenkinsfile passes the configurations to the cluster-post-config job. While in the Prow CI's script, we had some default values set. Shall we sync with Prow's default configurations? |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: liqcui The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Sync code with prow ci job
Jenkins job Log:
https://mastern-jenkins-csb-openshift-qe.apps.ocp-c1.prod.psi.redhat.com/job/scale-ci/job/liqcui-e2e-benchmarking-multibranch-pipeline/job/cluster-post-config/586/console
Has removed the
set -x
in openshift-qe-move-pods-infra-commands.sh, so ignore jenkins job's debug shell output