Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster post config #662

Open
wants to merge 2 commits into
base: cluster-post-config
Choose a base branch
from

Conversation

liqcui
Copy link

@liqcui liqcui commented Nov 8, 2024

Sync code with prow ci job
Jenkins job Log:
https://mastern-jenkins-csb-openshift-qe.apps.ocp-c1.prod.psi.redhat.com/job/scale-ci/job/liqcui-e2e-benchmarking-multibranch-pipeline/job/cluster-post-config/586/console

Has removed the set -x in openshift-qe-move-pods-infra-commands.sh, so ignore jenkins job's debug shell output

@liqcui
Copy link
Author

liqcui commented Nov 8, 2024

/assign @qiliRedHat

Jenkinsfile Outdated
@@ -23,6 +23,7 @@ pipeline {
'''
)
booleanParam(name:'INFRA_NODES', defaultValue:true, description:'If set to true, infra nodes machineset will be created, and options listed below will be used')
booleanParam(name:'IF_CREATE_WORKLOAD_NODE', defaultValue:true, description:'If set to true, creating workload machineset and nodes')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liqcui We can make the default value as false, because no workloads needs the workload node now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And in https://github.com/openshift-qe/ocp-qe-perfscale-ci/blob/cluster-workers-scaling/Jenkinsfile, I think we don't need the env vars related to the workload nodes too. I think you can remove them too.

@qiliRedHat
Copy link
Contributor

@liqcui In Jenkins, https://github.com/openshift-qe/ocp-qe-perfscale-ci/blob/cluster-workers-scaling/Jenkinsfile passes the configurations to the cluster-post-config job. While in the Prow CI's script, we had some default values set. Shall we sync with Prow's default configurations?

Copy link

openshift-ci bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liqcui
Once this PR has been reviewed and has the lgtm label, please ask for approval from qiliredhat. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liqcui
Copy link
Author

liqcui commented Nov 14, 2024

@liqcui In Jenkins, https://github.com/openshift-qe/ocp-qe-perfscale-ci/blob/cluster-workers-scaling/Jenkinsfile passes the configurations to the cluster-post-config job. While in the Prow CI's script, we had some default values set. Shall we sync with Prow's default configurations?
Submit a new pr to update default value #664

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants