Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NodeSwap with owner and doc blurb. #2053

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update NodeSwap with owner and doc blurb. #2053

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion features/features.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,11 @@ var (
enableIn(configv1.Default, configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
mustRegister()

// OpenShift and Node Team will keep this turned off until evictions and
// disk provisioning are fixed even though upstream will take this GA.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a mechanical level, when a feature is GA, kube removes the gating logic from code. Will we enforce this by preventing certain kubelet flags from being set?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes we'll turn it off by setting the KubeletConfiguration NoSwap value, and also keeping the fail-swap-on flag on. CNV will be able to turn on LimitedSwap and turn off fail-swap-on

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there will be something to block it, but the details have not been ironed out yet.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have plans to provide API level gating of that in MCO KubeletConfig controller (which hopefully will detect the presence of CNV to toggle the gating off, details still need to be figured out)

FeatureGateNodeSwap = newFeatureGate("NodeSwap").
reportProblemsToJiraComponent("node").
contactPerson("ehashman").
contactPerson("harche").
productScope(kubernetes).
enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
mustRegister()
Expand Down