MCO-1305: Promoting ManagedBootImagesAWS to default featureset

[djoshy]

This PR promotes the managed boot image feature for the AWS platform to GA for 4.18. It has supporting tests in openshift/origin here:

• MCO-1304: Add boot image update e2e tests origin#29099
• MCO-1370: Add boot image configmap test to openshift/origin origin#29219

Since this feature is not applicable for the Hypershift platform, it does not have Hypershift tests and it is failing for that variant in make verify. This should be safe to skip.

Query component readiness for all test run results for feature gate "ManagedBootImagesAWS" on clusterProfile ["Hypershift" "SelfManagedHA"]
Query component readiness for all test run results for pattern "FeatureGate:ManagedBootImagesAWS]" on variant main.JobVariant{Cloud:"aws", Architecture:"amd64", Topology:"hypershift", NetworkStack:""}
Query component readiness for all test run results for pattern "FeatureGate:ManagedBootImagesAWS]" on variant main.JobVariant{Cloud:"aws", Architecture:"amd64", Topology:"ha", NetworkStack:""}
INSUFFICIENT CI testing for "ManagedBootImagesAWS".
F1030 09:01:56.276374 2741335 root.go:64] Error running codegen: error: only 0 tests found, need at least 5 for "ManagedBootImagesAWS" on {aws amd64 hypershift }

[openshift-ci-robot]

@djoshy: This pull request references MCO-1305 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

This PR promotes the managed boot image feature for the AWS platform to GA for 4.18. It has supporting tests in openshift/origin here:

• MCO-1304: Add boot image update e2e tests origin#29099
• MCO-1370: Add boot image configmap test to openshift/origin origin#29219

Since this feature is not applicable for the Hypershift platform, it does not have Hypershift tests and it is failing for that variant in make verify. This should be safe to skip.

Query component readiness for all test run results for feature gate "ManagedBootImagesAWS" on clusterProfile ["Hypershift" "SelfManagedHA"]
Query component readiness for all test run results for pattern "FeatureGate:ManagedBootImagesAWS]" on variant main.JobVariant{Cloud:"aws", Architecture:"amd64", Topology:"hypershift", NetworkStack:""}
Query component readiness for all test run results for pattern "FeatureGate:ManagedBootImagesAWS]" on variant main.JobVariant{Cloud:"aws", Architecture:"amd64", Topology:"ha", NetworkStack:""}
INSUFFICIENT CI testing for "ManagedBootImagesAWS".
F1030 09:01:56.276374 2741335 root.go:64] Error running codegen: error: only 0 tests found, need at least 5 for "ManagedBootImagesAWS" on {aws amd64 hypershift }

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hello @djoshy! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: djoshy
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[JoelSpeed]

CRD generation appears to be out of date, please make sure to update the CRDs

[JoelSpeed]

Since this feature is not applicable for the Hypershift platform, it does not have Hypershift tests and it is failing for that variant in make verify. This should be safe to skip

The field is on MachineConfig right? Is MachineConfig not exposed in HyperShift? Why is this not applicable to HyperShift? Is there an enhancement that explains why?

Could you please ask QE to comment that they are happy with the feature promotion please

Also, I noticed that this test and this test were failing a week ago, do we know why they were failing, and has a fix been made?

[djoshy]

Since this feature is not applicable for the Hypershift platform, it does not have Hypershift tests and it is failing for that variant in make verify. This should be safe to skip

The field is on MachineConfig right? Is MachineConfig not exposed in HyperShift? Why is this not applicable to HyperShift? Is there an enhancement that explains why?

https://github.com/openshift/enhancements/blob/master/enhancements%2Fmachine-config%2Fmanage-boot-images.md#non-goals

As we understand it, Hypershift uses NodePools and not MachineSets, so this feature is not applicable for them

Could you please ask QE to comment that they are happy with the feature promotion please

Will do!

Also, I noticed that this test and this test were failing a week ago, do we know why they were failing, and has a fix been made?

This was a timeout issue(possibly due to slow cleanup from an unrelated test that ran before it) : openshift/origin#29210; https://issues.redhat.com//browse/OCPBUGS-43512. This would cascade on to the other test, but the root cause was not giving enough time for the test listed in the bug to not finish.

[sergiordlr]

Hello! We will start the pre-merge verification of this feature ASAP.

We hold it until we can add the qe-approved label. Please, @ptalgulk01 , could you start the pre-merge testing? thanks!

/hold

[djoshy]

/retest-required

[ptalgulk01]

Pre-merge verification commented here: https://issues.redhat.com/browse/MCO-1335?focusedCommentId=25984304&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-25984304

Once this jobs are completed I will add QE approved label .

[openshift-ci]

@djoshy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify	9d54824	link	true	/test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.