-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-19080: Enable installation of 3-5 control plane cluster in day1 #6917
base: master
Are you sure you want to change the base?
Conversation
@danmanor: This pull request references MGMT-19080 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danmanor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2a91b66
to
7147aaf
Compare
7147aaf
to
7ba4240
Compare
/test |
@danmanor: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test edge-e2e-metal-assisted-5-control-planes-4-18 /test edge-e2e-metal-assisted-4-control-planes-4-18 |
/test |
@danmanor: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test |
@danmanor: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test edge-e2e-ai-operator-ztp-4masters /test edge-e2e-ai-operator-ztp-5masters |
/test edge-e2e-ai-operator-ztp |
@danmanor: This pull request references MGMT-19080 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@danmanor: This pull request references MGMT-19080 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
1 similar comment
@danmanor: This pull request references MGMT-19080 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@danmanor: This pull request references MGMT-19080 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6917 +/- ##
==========================================
- Coverage 68.70% 68.70% -0.01%
==========================================
Files 249 249
Lines 37441 37476 +35
==========================================
+ Hits 25724 25748 +24
- Misses 9416 9429 +13
+ Partials 2301 2299 -2
|
/override ci/prow/edge-e2e-metal-assisted-mtv-4-17 |
/test edge-e2e-ai-operator-ztp-4masters edge-e2e-ai-operator-ztp-5masters |
@danmanor: Overrode contexts on behalf of danmanor: ci/prow/edge-e2e-metal-assisted-mtv-4-17 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override ci/prow/edge-e2e-ai-operator-disconnected-capi |
@danmanor: Overrode contexts on behalf of danmanor: ci/prow/edge-e2e-ai-operator-disconnected-capi In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@danmanor: This pull request references MGMT-19080 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/override ci/prow/edge-e2e-ai-operator-disconnected-capi |
@danmanor: Overrode contexts on behalf of danmanor: ci/prow/edge-e2e-ai-operator-disconnected-capi In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/hold |
/test edge-e2e-ai-operator-ztp-4masters edge-e2e-ai-operator-ztp-5masters |
7ba4240
to
4e3ddf4
Compare
4e3ddf4
to
7ab9da5
Compare
7ab9da5
to
0039834
Compare
/test edge-e2e-metal-assisted-4-control-planes-4-18 edge-e2e-metal-assisted-5-control-planes-4-18 |
/test edge-e2e-metal-assisted-odf-4-17 |
@danmanor: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
currently assisted-service enables only SNO or 3CP clusters in day1. With the new feature in OCP 4.17 / OCP 4.18 enabling installation of 4/5 control planes as well, this PR enables it in assisted-service.
https://issues.redhat.com/browse/OCPSTRAT-1199
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs
, README, etc)Reviewers Checklist