Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-42705: Use icsp/idms for oc commands instead of releaseMirror #6918

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

OCPBUGS-42705: Use icsp/idms for oc commands instead of releaseMirror #6918

wants to merge 1 commit into from
+65 −70

Conversation

bfournie
Copy link
Contributor

@bfournie bfournie commented Oct 15, 2024 •
edited
Loading

Currently, the local image mirror url is used when running the 'oc' commands. This can cause a problem if the mirror configuration has multiple mirrors, since there will be no failover if the url is unreachable. Instead, the actual releaseImage should be used when the icsp or idms configuration is provided to ensure proper failover.

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • [] No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

@bfournie
OCPBUGS-42705: Use icsp/idms for oc commands instead of releaseImageM…
7551872 
…irror

Currently, the local image mirror url is used when running the 'oc'
commands. This can cause a problem if the mirror configuration has
multiple mirrors, since there will be no failover if the url is
unreachable. Instead, the actual releaseImage should be used when the
icsp or idms configuration is provided to ensure proper failover.
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 15, 2024
@openshift-ci-robot
Copy link

@bfournie: This pull request references Jira Issue OCPBUGS-42705, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mhanss

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

…irror

Currently, the local image mirror url is used when running the 'oc' commands. This can cause a problem if the mirror configuration has multiple mirrors, since there will be no failover if the url is unreachable. Instead, the actual releaseImage should be used when the icsp or idms configuration is provided to ensure proper failover.

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • [] No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from mhanss October 15, 2024 19:09
@bfournie bfournie changed the title OCPBUGS-42705: Use icsp/idms for oc commands instead of releaseImageM… OCPBUGS-42705: Use icsp/idms for oc commands instead of releaseMirror Oct 15, 2024
@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 15, 2024
@openshift-ci-robot
Copy link

@bfournie: This pull request references Jira Issue OCPBUGS-42705, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mhanss

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Currently, the local image mirror url is used when running the 'oc' commands. This can cause a problem if the mirror configuration has multiple mirrors, since there will be no failover if the url is unreachable. Instead, the actual releaseImage should be used when the icsp or idms configuration is provided to ensure proper failover.

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • [] No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bfournie
Once this PR has been reviewed and has the lgtm label, please assign eranco74 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov Codecov
Copy link

codecov bot commented Oct 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 79.16667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 68.72%. Comparing base (cd37030) to head (7551872).
Report is 23 commits behind head on master.

Files with missing lines Patch % Lines
internal/oc/release.go 79.16% 6 Missing and 4 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6918      +/-   ##
==========================================
- Coverage   68.73%   68.72%   -0.02%     
==========================================
  Files         249      249              
  Lines       37439    37435       -4     
==========================================
- Hits        25734    25726       -8     
- Misses       9405     9410       +5     
+ Partials     2300     2299       -1
Files with missing lines Coverage Δ
internal/oc/release.go 75.00% <79.16%> (+1.48%) ⬆️

... and 4 files with indirect coverage changes

@bfournie
Copy link
Contributor Author

/test e2e-agent-ha-dualstack
/test e2e-agent-sno-ipv6

4 similar comments
@bfournie
Copy link
Contributor Author

/test e2e-agent-ha-dualstack
/test e2e-agent-sno-ipv6

@bfournie
Copy link
Contributor Author

/test e2e-agent-ha-dualstack
/test e2e-agent-sno-ipv6

@bfournie
Copy link
Contributor Author

/test e2e-agent-ha-dualstack
/test e2e-agent-sno-ipv6

@bfournie
Copy link
Contributor Author

/test e2e-agent-ha-dualstack
/test e2e-agent-sno-ipv6

@bfournie
Copy link
Contributor Author

/retest

@bfournie
Copy link
Contributor Author

bfournie commented Nov 1, 2024

/test e2e-agent-ha-dualstack
/test e2e-agent-sno-ipv6

@bfournie
Copy link
Contributor Author

bfournie commented Nov 1, 2024

/test e2e-agent-sno-ipv6

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 1, 2024

@bfournie: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-sno-ipv6 7551872 link false /test e2e-agent-sno-ipv6
ci/prow/e2e-agent-ha-dualstack 7551872 link false /test e2e-agent-ha-dualstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhanss mhanss Awaiting requested review from mhanss

@eliorerz eliorerz Awaiting requested review from eliorerz

@gamli75 gamli75 Awaiting requested review from gamli75

Assignees
No one assigned
Labels
jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bfournie @openshift-ci-robot