Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-19174: [cloud_hotfix_release] add rpms signature scan #6949

Open
wants to merge 1 commit into
base: cloud_hotfix_releases
Choose a base branch
from

Conversation

pastequo
Copy link
Contributor

Release pipeline ECP will make this task mandatory starting November 1st

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2024
@pastequo pastequo changed the base branch from master to cloud_hotfix_releases October 28, 2024 14:20
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2024
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 28, 2024
@pastequo pastequo changed the title Ci/add rpms signature scan [cloud_hotfix_release] Ci/add rpms signature scan Oct 28, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2024
@pastequo pastequo changed the title [cloud_hotfix_release] Ci/add rpms signature scan MGMT-19174: [cloud_hotfix_release] add rpms signature scan Oct 28, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 28, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 28, 2024

@pastequo: This pull request references MGMT-19174 which is a valid jira issue.

In response to this:

Release pipeline ECP will make this task mandatory starting November 1st

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pastequo
Copy link
Contributor Author

/retest

1 similar comment
@pastequo
Copy link
Contributor Author

/retest

Copy link

openshift-ci bot commented Oct 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pastequo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Oct 30, 2024

@pastequo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/edge-verify-generated-code cbc9580 link true /test edge-verify-generated-code
ci/prow/edge-unit-test cbc9580 link true /test edge-unit-test
ci/prow/edge-e2e-metal-assisted-mtv-4-17 cbc9580 link true /test edge-e2e-metal-assisted-mtv-4-17
ci/prow/edge-e2e-metal-assisted-lvm cbc9580 link true /test edge-e2e-metal-assisted-lvm
ci/prow/edge-e2e-metal-assisted-day2-single-node cbc9580 link false /test edge-e2e-metal-assisted-day2-single-node
ci/prow/edge-e2e-metal-assisted-cnv-4-17 cbc9580 link true /test edge-e2e-metal-assisted-cnv-4-17
ci/prow/edge-e2e-metal-assisted-ipv4v6 cbc9580 link false /test edge-e2e-metal-assisted-ipv4v6
ci/prow/edge-e2e-metal-assisted-day2 cbc9580 link false /test edge-e2e-metal-assisted-day2
ci/prow/edge-ci-index cbc9580 link true /test edge-ci-index
ci/prow/edge-images cbc9580 link true /test edge-images
ci/prow/edge-subsystem-kubeapi-aws cbc9580 link true /test edge-subsystem-kubeapi-aws
ci/prow/edge-e2e-metal-assisted-static-ip-suite cbc9580 link false /test edge-e2e-metal-assisted-static-ip-suite
ci/prow/e2e-agent-compact-ipv4 cbc9580 link true /test e2e-agent-compact-ipv4
ci/prow/edge-e2e-metal-assisted-bond cbc9580 link false /test edge-e2e-metal-assisted-bond
ci/prow/edge-e2e-metal-assisted-static-ip-suite-4-14 cbc9580 link false /test edge-e2e-metal-assisted-static-ip-suite-4-14
ci/prow/edge-e2e-metal-assisted-odf-4-17 cbc9580 link true /test edge-e2e-metal-assisted-odf-4-17
ci/prow/edge-e2e-metal-assisted-single-node cbc9580 link false /test edge-e2e-metal-assisted-single-node
ci/prow/edge-assisted-operator-catalog-publish-verify cbc9580 link true /test edge-assisted-operator-catalog-publish-verify
ci/prow/edge-subsystem-aws cbc9580 link true /test edge-subsystem-aws
ci/prow/edge-e2e-metal-assisted cbc9580 link true /test edge-e2e-metal-assisted
ci/prow/edge-e2e-ai-operator-ztp cbc9580 link true /test edge-e2e-ai-operator-ztp
ci/prow/edge-lint cbc9580 link true /test edge-lint
ci/prow/edge-e2e-metal-assisted-bond-4-14 cbc9580 link false /test edge-e2e-metal-assisted-bond-4-14
ci/prow/mce-images cbc9580 link true /test mce-images
ci/prow/e2e-metal-assisted-static-ip-suite 7e81e39 link true /test e2e-metal-assisted-static-ip-suite
ci/prow/unit-test 7e81e39 link true /test unit-test
ci/prow/e2e-metal-assisted-single-node 7e81e39 link true /test e2e-metal-assisted-single-node
ci/prow/e2e-metal-assisted 7e81e39 link false /test e2e-metal-assisted
ci/prow/e2e-metal-assisted-ipv4v6 7e81e39 link true /test e2e-metal-assisted-ipv4v6
ci/prow/e2e-metal-assisted-day2 7e81e39 link true /test e2e-metal-assisted-day2
ci/prow/images 7e81e39 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants