MGMT-19670, MGMT-19484: Enable multipath + iSCSI as installation disk #7192
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@linoyaslan: This pull request references MGMT-19670 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. This pull request references MGMT-19484 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: linoyaslan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@linoyaslan: This pull request references MGMT-19670 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. This pull request references MGMT-19484 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cc @adriengentil |
|
@linoyaslan: This pull request references MGMT-19670 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. This pull request references MGMT-19484 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
linoyaslan
changed the title
linoyaslan
force-pushed
the
MGMT-19670.enable_multipath
branch
from
e9a87b7 to
cea6d01
Compare
| dhcp = "dhcp6" | ||
| } | ||
| installerArgs = append(installerArgs, "--append-karg", fmt.Sprintf("ip=%s:%s", nic.Name, dhcp)) | ||
| break |
There was a problem hiding this comment.
we may have several disks connected through different interfaces, I think we should not break
linoyaslan
force-pushed
the
MGMT-19670.enable_multipath
branch
from
cea6d01 to
564e22b
Compare
|
@linoyaslan: This pull request references MGMT-19670 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. This pull request references MGMT-19484 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@linoyaslan: This pull request references MGMT-19670 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. This pull request references MGMT-19484 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@linoyaslan: This pull request references MGMT-19670 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. This pull request references MGMT-19484 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
1 similar comment
|
@linoyaslan: This pull request references MGMT-19670 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. This pull request references MGMT-19484 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@linoyaslan: This pull request references MGMT-19670 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. This pull request references MGMT-19484 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@linoyaslan: This pull request references MGMT-19670 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. This pull request references MGMT-19484 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@linoyaslan: This pull request references MGMT-19670 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. This pull request references MGMT-19484 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
linoyaslan
force-pushed
the
MGMT-19670.enable_multipath
branch
from
564e22b to
c6e41ad
Compare
openshift-ci
bot
added
size/L
linoyaslan
force-pushed
the
MGMT-19670.enable_multipath
branch
from
de6efcb to
8cc5d7e
Compare
|
@linoyaslan: This pull request references MGMT-19670 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. This pull request references MGMT-19484 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@linoyaslan: This pull request references MGMT-19670 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. This pull request references MGMT-19484 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@linoyaslan: This pull request references MGMT-19670 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. This pull request references MGMT-19484 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
linoyaslan
force-pushed
the
MGMT-19670.enable_multipath
branch
from
8cc5d7e to
392be71
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
linoyaslan
force-pushed
the
MGMT-19670.enable_multipath
branch
2 times, most recently
from
2843494 to
8c84b31
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7192 +/- ##
==========================================
- Coverage 67.93% 67.88% -0.05%
==========================================
Files 300 298 -2
Lines 40900 40747 -153
==========================================
- Hits 27784 27662 -122
+ Misses 10625 10604 -21
+ Partials 2491 2481 -10
|
openshift-ci
bot
added
the
do-not-merge/work-in-progress
linoyaslan
force-pushed
the
MGMT-19670.enable_multipath
branch
4 times, most recently
from
ecb0862 to
69a6f4e
Compare
linoyaslan
force-pushed
the
MGMT-19670.enable_multipath
branch
2 times, most recently
from
893ae98 to
579c5d9
Compare
| } | ||
| // We only allow multipath if all paths are of the same type | ||
| if len(fcDisks) > 0 && len(fcDisks) != len(hostutil.GetAllDisksOfHolder(inventory.Disks, disk)) { | ||
| notEligibleReasons = append(notEligibleReasons, mixedTypesInMultipath) |
There was a problem hiding this comment.
| notEligibleReasons = append(notEligibleReasons, mixedTypesInMultipath) | |
| return append(notEligibleReasons, mixedTypesInMultipath), nil |
I think we can return here and below as well?
There was a problem hiding this comment.
I considered that, but if there are issues with the iSCSI disks, wouldn’t it be better to display all the issues to the user at once?
| } else if len(iSCSIDisks) > 0 && len(iSCSIDisks) != len(hostutil.GetAllDisksOfHolder(inventory.Disks, disk)) { | ||
| notEligibleReasons = append(notEligibleReasons, mixedTypesInMultipath) | ||
| } |
There was a problem hiding this comment.
| } else if len(iSCSIDisks) > 0 && len(iSCSIDisks) != len(hostutil.GetAllDisksOfHolder(inventory.Disks, disk)) { | |
| notEligibleReasons = append(notEligibleReasons, mixedTypesInMultipath) | |
| } | |
| if len(iSCSIDisks) > 0 && len(iSCSIDisks) != len(hostutil.GetAllDisksOfHolder(inventory.Disks, disk)) { | |
| return append(notEligibleReasons, mixedTypesInMultipath), nil | |
| } |
This commit removes the disablement of multipath+iSCSI, updates the required kernel arguments, and extends the `nicReapplyManifest` workaround previously added for iSCSI to also support multipath+iSCSI.
This commit expand the 2 iSCSI validations, one during the discovery phase, which checks that the iSCSI disk is not connected through the default network interface (the one used by the default gateway), and another during the networking stage, ensuring that the disk does not belong to the machine's network.
linoyaslan
force-pushed
the
MGMT-19670.enable_multipath
branch
from
579c5d9 to
c5f9924
Compare
Building on the work done to enable iSCSI as an installation disk, this PR extends support to enable multipath+iSCSI as an installation disk.
Details about the testing setup will be added here later - https://github.com/openshift/assisted-service/blob/master/docs/dev/multipath.md
/cc @adriengentil
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs, README, etc)Reviewers Checklist