ACM-17553: Save version of imported clusters - ACM 2.12

[jhernand]

This is a backport of OCPBUGS-42059 and #7249 for ACM 2.12.

Currently when a cluster is imported the openshift_version column of the database is not populated. As a result that version will not be available for validations, in particular for the validation that checks if dual-stack VIPs are supported. A side effect of that is that adding a node to a cluster with dual-stack VIPs will always fail with an error message like this, regardless of the version:

"dual-stack VIPs are not supported in OpenShift "

That error happens because we are trying to see if the version is less than 4.12, but the result is always true because the version is empty.

To avoid that this patch changes the cluster import code so that it populates the openshift_version database column.

List all the issues related to this PR

https://issues.redhat.com/browse/ACM-17553
https://issues.redhat.com/browse/OCPBUGS-42059

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[openshift-ci-robot]

@jhernand: This pull request references ACM-17553 which is a valid jira issue.

In response to this:

This is a backport of OCPBUGS-42059 and #7249 for ACM 2.12.

Currently when a cluster is imported the openshift_version column of the database is not populated. As a result that version will not be available for validations, in particular for the validation that checks if dual-stack VIPs are supported. A side effect of that is that adding a node to a cluster with dual-stack VIPs will always fail with an error message like this, regardless of the version:

"dual-stack VIPs are not supported in OpenShift "

That error happens because we are trying to see if the version is less than 4.12, but the result is always true because the version is empty.

To avoid that this patch changes the cluster import code so that it populates the openshift_version database column.

List all the issues related to this PR

https://issues.redhat.com/browse/ACM-17553
https://issues.redhat.com/browse/OCPBUGS-42059

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jhernand
Once this PR has been reviewed and has the lgtm label, please assign pastequo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.31%. Comparing base (a5e16aa) to head (4671cf3).

Additional details and impacted files

@@                Coverage Diff                @@
##           release-ocm-2.12    #7250   +/-   ##
=================================================
  Coverage             68.30%   68.31%           
=================================================
  Files                   257      257           
  Lines                 37611    37614    +3     
=================================================
+ Hits                  25692    25695    +3     
  Misses                 9635     9635           
  Partials               2284     2284           

Files with missing lines	Coverage Δ
internal/bminventory/inventory.go	70.71% <100.00%> (+<0.01%)	⬆️
...oller/controllers/clusterdeployments_controller.go	71.57% <100.00%> (+0.03%)	⬆️

[gamli75]

/retest-required

[openshift-ci]

@jhernand: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/subsystem-aws	4671cf3	link	true	/test subsystem-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.