[DPTP-4274] Allow requests for ephemeral-storage in validation/config.go

[jiridanek]

https://issues.redhat.com/browse/DPTP-4274

I have a question in Red Hat Internal #forum-ocp-platform

Can I set ephemeral-storage in the BuildConfig used to build my image?

https://redhat-internal.slack.com/archives/CBN38N3MW/p1722437504182729

The answer given there was a "no". I want it to be yes. I am guessing line 570 in validation/config.go is stopping me. I change line 570.

I did not test this in any way. I don't even have a local checkout of this repo. If you think this is a viable route, I'd test it.

Since there are good prospects getting this in, I added unittest and played with this locally a bit. I also created a Jira ticket.

[jiridanek]

/label tide/merga-method-squash

[openshift-ci]

@jiridanek: The label(s) /label tide/merga-method-squash cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label tide/merga-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jiridanek]

/label tide/merge-method-squash

[jiridanek]

error: error creating buildah builder: choosing an image from manifest list docker://image-registry.openshift-image-registry.svc:5000/ci-op-hls38x5i/pipeline@sha256:b318c56ee5d134cbaeba41d1b00143d5a19ba790600be0a7fdfc3df61dc579c0: no image found in manifest list for architecture amd64, variant "", OS linux

did I break the CI?

[openshift-ci-robot]

@jiridanek: This pull request references DPTP-4274 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

I have a question in Red Hat Internal #forum-ocp-platform

Can I set ephemeral-storage in the BuildConfig used to build my image?

https://redhat-internal.slack.com/archives/CBN38N3MW/p1722437504182729

The answer given there was a "no". I want it to be yes. I am guessing line 570 in validation/config.go is stopping me. I change line 570.

I did not test this in any way. I don't even have a local checkout of this repo. If you think this is a viable route, I'd test it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@jiridanek: This pull request references DPTP-4274 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/DPTP-4274

I have a question in Red Hat Internal #forum-ocp-platform

Can I set ephemeral-storage in the BuildConfig used to build my image?

https://redhat-internal.slack.com/archives/CBN38N3MW/p1722437504182729

The answer given there was a "no". I want it to be yes. I am guessing line 570 in validation/config.go is stopping me. I change line 570.

I did not test this in any way. I don't even have a local checkout of this repo. If you think this is a viable route, I'd test it.

Since there are good prospects getting this in, I added unittest and played with this locally a bit. I also created a Jira ticket.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@jiridanek: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

https://issues.redhat.com/browse/DPTP-4274

I have a question in Red Hat Internal #forum-ocp-platform

Can I set ephemeral-storage in the BuildConfig used to build my image?

https://redhat-internal.slack.com/archives/CBN38N3MW/p1722437504182729

The answer given there was a "no". I want it to be yes. I am guessing line 570 in validation/config.go is stopping me. I change line 570.

I did not test this in any way. I don't even have a local checkout of this repo. If you think this is a viable route, I'd test it.

Since there are good prospects getting this in, I added unittest and played with this locally a bit. I also created a Jira ticket.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[smg247]

I don't think this will actually do anything. You have modified validation logic which will let your ci-operator config be updated to include ephemeral-storage, but you haven't actually propagated that to the container or pod (or wherever it needs to go).

[jiridanek]

You have modified validation logic which will let your ci-operator config be updated to include ephemeral-storage, but you haven't actually propagated that to the container or pod (or wherever it needs to go).

I did not know something more is still needed. I'm looking for the place that needs to be updating.

[jiridanek]

You have modified validation logic which will let your ci-operator config be updated to include ephemeral-storage, but you haven't actually propagated that to the container or pod (or wherever it needs to go).

@smg247 I spent some time on this but I just could not find the right spot that I'm supposed to update. Can you (or @jmguzik who's the Jira assignee) help me by pointing out the way? Or just do the change for me.

So far I've been only running some select ci-operator tests, I never even deployed the whole thing end-to-end.

[smg247]

I don't have the bandwidth to implement this right now, but the jira will follow our normal grooming and prioritization procedures. Obviously implementing this yourself would expedite the process, but if one of us has to do it, it will take longer.

[smg247]

/uncc

[jmguzik]

I analyzed this today briefly and I think there is a chance it will work. Validation is allowed now and later these arguments are passed further. The thing is idk what is actually needed to have this storage enabled, but I guess we can try an experiment. Get it passing all tests and refresh and then we will learn what is missing.

This is of course after brief analysis and taking into account assumption your test fails on that check right now. Unfortunately I have no time to dedicate more cycles into this one.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jiridanek
Once this PR has been reviewed and has the lgtm label, please assign pruan-rht for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jiridanek]

@jmguzik thanks for this! So, maybe that's why I was not able to find the place to update next; but more likely it was just because I can't effectively navigate the unfamilar codebase.

PR updated, let's see how it goes through CI.

[jiridanek]

I'm seeing infra issues, retriggering

/test images
/test breaking-changes

  * could not run steps: step bin failed: error occurred handling build bin-amd64: build not successful after 5 attempts: [the build bin-amd64 failed after 39m54s with reason PushImageToRegistryFailed: Failed to push the image to the registry., the build bin-amd64 failed after 2m1s with reason PullBuilderImageFailed: Failed pulling builder image., the build bin-amd64 failed after 4m21s with reason PullBuilderImageFailed: Failed pulling builder image., the build bin-amd64 failed after 12m1s with reason PullBuilderImageFailed: Failed pulling builder image., the build bin-amd64 failed after 1m7s with reason PullBuilderImageFailed: Failed pulling builder image.] 

I'm unsure what the other fail is about, but I'll rerun breaking-changes test as well, just in case it helps any

ERROR: Running cluster-init in update mode in openshift/release results in changes ^^^
ERROR: To avoid breaking openshift/release for everyone you should regenerate the build clusters
ERROR: there and merge the changes ASAP after this change to cluster-init

edit: not helping, let me rebase again

[openshift-ci-robot]

/test remaining-required

[openshift-ci-robot]

/test remaining-required

[openshift-ci]

@jiridanek: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	9d612b0	link	false	/test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[jmguzik]

/ci/prow/breaking-changes

[jmguzik]

/test ci/prow/breaking-changes

[openshift-ci]

@jmguzik: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test checkconfig

/test codegen

/test e2e

/test format

/test frontend-checks

/test images

/test integration

/test lint

/test unit

/test validate-prow

/test validate-vendor

The following commands are available to trigger optional jobs:

/test breaking-changes

/test e2e-oo

/test secret-bootstrapper-validation

/test secret-generator-validation

/test security

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-ci-tools-master-breaking-changes

pull-ci-openshift-ci-tools-master-checkconfig

pull-ci-openshift-ci-tools-master-codegen

pull-ci-openshift-ci-tools-master-format

pull-ci-openshift-ci-tools-master-frontend-checks

pull-ci-openshift-ci-tools-master-images

pull-ci-openshift-ci-tools-master-integration

pull-ci-openshift-ci-tools-master-lint

pull-ci-openshift-ci-tools-master-secret-bootstrapper-validation

pull-ci-openshift-ci-tools-master-secret-generator-validation

pull-ci-openshift-ci-tools-master-security

pull-ci-openshift-ci-tools-master-unit

pull-ci-openshift-ci-tools-master-validate-prow

pull-ci-openshift-ci-tools-master-validate-vendor

In response to this:

/test ci/prow/breaking-changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jmguzik]

Not sure why this one failing on breaking changes, let me retest.

[jiridanek]

/test breaking-changes