-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(import): make dropdown mandatory #1009
base: main
Are you sure you want to change the base?
fix(import): make dropdown mandatory #1009
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1009 +/- ##
==========================================
- Coverage 84.94% 84.94% -0.01%
==========================================
Files 580 580
Lines 14189 14192 +3
Branches 3967 3969 +2
==========================================
+ Hits 12053 12055 +2
- Misses 2009 2010 +1
Partials 127 127
Continue to review full report in Codecov by Sentry.
|
Co-authored-by: Martin <[email protected]>
@abhinandan13jan: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
Hi, I created one related PR #1015 which is based on yours. The PR fixed the https, !1015 ensure the gitlab is auto-filled for that case . |
BTW, if we just support github & gitlab, do we need to do some code cleanup for the original other type git provider like 'bitbucket.org'? |
FYI. #1015 has been closed directly. Thank you for your help and suggestion. |
/lgtm |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinandan13jan, sahil143 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test test |
@abhinandan13jan: The
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fixes
https://issues.redhat.com/browse/KFLUXBUGS-1745
Description
Makes selection of git-provider annotation mandatory
Adds https:// to the git-url annotation
Type of change
Screen shots / Gifs for design review
How to test or reproduce?
Browser conformance: