Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(import): make dropdown mandatory #1009

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

abhinandan13jan
Copy link
Contributor

Fixes

https://issues.redhat.com/browse/KFLUXBUGS-1745

Description

Makes selection of git-provider annotation mandatory
Adds https:// to the git-url annotation

Type of change

  • Feature
  • Bugfix
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Screen shots / Gifs for design review

Screenshot 2024-10-18 at 4 56 25 PM Screenshot 2024-10-18 at 4 56 39 PM Screenshot 2024-10-18 at 4 58 16 PM

How to test or reproduce?

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.94%. Comparing base (26babff) to head (e17c309).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
...mportForm/ComponentSection/GitProviderDropdown.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1009      +/-   ##
==========================================
- Coverage   84.94%   84.94%   -0.01%     
==========================================
  Files         580      580              
  Lines       14189    14192       +3     
  Branches     3967     3969       +2     
==========================================
+ Hits        12053    12055       +2     
- Misses       2009     2010       +1     
  Partials      127      127              
Files with missing lines Coverage Δ
...ents/ImportForm/ComponentSection/SourceSection.tsx 97.77% <100.00%> (ø)
src/components/ImportForm/validation.utils.ts 100.00% <ø> (ø)
...mportForm/ComponentSection/GitProviderDropdown.tsx 84.61% <75.00%> (-5.39%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26babff...e17c309. Read the comment docs.

Copy link
Contributor

openshift-ci bot commented Oct 18, 2024

@abhinandan13jan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@testcara
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2024
@testcara
Copy link
Contributor

testcara commented Oct 30, 2024

Hi, I created one related PR #1015 which is based on yours.
I went through the KFLUXBUGS-1786 & KFLUXBUGS-1786, it seems users expect when inputting 'https://gitlab.cee.redhat.com/test.git', the git provider should be gitlab and https://gitlab.cee.redhat.com.

The PR fixed the https, !1015 ensure the gitlab is auto-filled for that case .
Please also help to review !1015 to confirm it is useful or not.
Thank you so much.

@testcara
Copy link
Contributor

BTW, if we just support github & gitlab, do we need to do some code cleanup for the original other type git provider like 'bitbucket.org'?

@testcara
Copy link
Contributor

testcara commented Nov 1, 2024

FYI. #1015 has been closed directly. Thank you for your help and suggestion.

@CryptoRodeo
Copy link
Contributor

/lgtm

@marcin-michal
Copy link
Contributor

/lgtm

Copy link
Contributor

@sahil143 sahil143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented Nov 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinandan13jan, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2024
@abhinandan13jan
Copy link
Contributor Author

abhinandan13jan commented Nov 5, 2024

/test test

Copy link
Contributor

openshift-ci bot commented Nov 5, 2024

@abhinandan13jan: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test images
  • /test test

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants