Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS-3741: [Nutanix] support multiple subnets #9133

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yanhua121
Copy link
Contributor

@yanhua121 yanhua121 commented Oct 23, 2024

CORS-3741
Allow users to configure multiple subnets via platform.nutanix.subnetUUIDs in the install-config.yaml.

Depends on openshift/api#2077

@yanhua121
Copy link
Contributor Author

/test e2e-nutanix-ovn

@yanhua121
Copy link
Contributor Author

/test e2e-nutanix-ovn

@yanhua121
Copy link
Contributor Author

/assign @r4f4

@r4f4
Copy link
Contributor

r4f4 commented Oct 30, 2024

@yanhua121 is this feature tracked in Jira? If so, can you link it to this PR?

@r4f4
Copy link
Contributor

r4f4 commented Oct 30, 2024

/hold

Until openshift/api#2077 merges

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 30, 2024
@yanhua121 yanhua121 changed the title Nutanix: support multiple subnets CORS-3741: [Nutanix] support multiple subnets Oct 30, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 30, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 30, 2024

@yanhua121: This pull request references CORS-3741 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set.

In response to this:

Allow users to configure multiple subnets via platform.nutanix.subnetUUIDs in the install-config.yaml.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 30, 2024

@yanhua121: This pull request references CORS-3741 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set.

In response to this:

CORS-3741
Allow users to configure multiple subnets via platform.nutanix.subnetUUIDs in the install-config.yaml.

Depends on openshift/api#2077

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Oct 31, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from r4f4. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Nov 1, 2024

@yanhua121: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants