-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify HW configuration to enable or disable T-GM Holdover #370
base: master
Are you sure you want to change the base?
Conversation
@aneeshkp: This pull request references Jira Issue OCPBUGS-43442, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aneeshkp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
618da62
to
5896c4c
Compare
Signed-off-by: Aneesh Puttur <[email protected]>
5896c4c
to
3d70f88
Compare
/jira refresh |
@aneeshkp: This pull request references Jira Issue OCPBUGS-43442, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@aneeshkp: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@aneeshkp: No Jira issue is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/hold |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Added check to verify dependency and linter fixes
The dependency Checker iterates over the interfaces (p.ifaces) associated with the _ptpProcess.
Checking for DPLL Requirement:
For each interface, it checks if the source is either GNSS or PPS, AND if the process name is ts2phcProcessName.
adds dpll.DPLL_PROCESSNAME to the deps map.
Adding GPSD and GPSPIPE Dependencies:
If the interface source is GNSS and the process name is ts2phcProcessName, it adds GPSD_PROCESSNAME and GPSPIPE_PROCESSNAME to the deps map