Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify HW configuration to enable or disable T-GM Holdover #370

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aneeshkp
Copy link
Contributor

Added check to verify dependency and linter fixes

The dependency Checker iterates over the interfaces (p.ifaces) associated with the _ptpProcess.
Checking for DPLL Requirement:
For each interface, it checks if the source is either GNSS or PPS, AND if the process name is ts2phcProcessName.
adds dpll.DPLL_PROCESSNAME to the deps map.
Adding GPSD and GPSPIPE Dependencies:
If the interface source is GNSS and the process name is ts2phcProcessName, it adds GPSD_PROCESSNAME and GPSPIPE_PROCESSNAME to the deps map

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 16, 2024
@openshift-ci-robot
Copy link
Contributor

@aneeshkp: This pull request references Jira Issue OCPBUGS-43442, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Added check to verify dependency and linter fixes

The dependency Checker iterates over the interfaces (p.ifaces) associated with the _ptpProcess.
Checking for DPLL Requirement:
For each interface, it checks if the source is either GNSS or PPS, AND if the process name is ts2phcProcessName.
adds dpll.DPLL_PROCESSNAME to the deps map.
Adding GPSD and GPSPIPE Dependencies:
If the interface source is GNSS and the process name is ts2phcProcessName, it adds GPSD_PROCESSNAME and GPSPIPE_PROCESSNAME to the deps map

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 16, 2024
Copy link
Contributor

openshift-ci bot commented Oct 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aneeshkp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2024
@aneeshkp
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Oct 16, 2024
@openshift-ci-robot
Copy link
Contributor

@aneeshkp: This pull request references Jira Issue OCPBUGS-43442, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 16, 2024
Copy link
Contributor

openshift-ci bot commented Oct 16, 2024

@aneeshkp: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@aneeshkp aneeshkp changed the title OCPBUGS-43442: Verify HW configuration to enable or disable T-GM Holdover Verify HW configuration to enable or disable T-GM Holdover Oct 23, 2024
@openshift-ci-robot openshift-ci-robot removed jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 23, 2024
@openshift-ci-robot
Copy link
Contributor

@aneeshkp: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Added check to verify dependency and linter fixes

The dependency Checker iterates over the interfaces (p.ifaces) associated with the _ptpProcess.
Checking for DPLL Requirement:
For each interface, it checks if the source is either GNSS or PPS, AND if the process name is ts2phcProcessName.
adds dpll.DPLL_PROCESSNAME to the deps map.
Adding GPSD and GPSPIPE Dependencies:
If the interface source is GNSS and the process name is ts2phcProcessName, it adds GPSD_PROCESSNAME and GPSPIPE_PROCESSNAME to the deps map

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@aneeshkp
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 25, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 29, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants