Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[interna-fix] on-premise-accept-text-file #77082

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Jun 6, 2024

"On-premise" in the context of bundling bare-metal, vSphere, Nutanix, and OpenStack platforms is a valid term. Example.

See the following PRs for why this exception is needed:

  • RH SSG repo: 487
  • Vale repo: 798

@dfitzmau dfitzmau force-pushed the on-premise-accept-text-file branch from 4b172ba to 92d4a99 Compare June 6, 2024 11:08
@dfitzmau dfitzmau changed the title on-premise-accept-text-file [interna-fix] on-premise-accept-text-file Jun 6, 2024
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 6, 2024
@dfitzmau dfitzmau force-pushed the on-premise-accept-text-file branch from 92d4a99 to 68f9f5e Compare June 6, 2024 11:12
Copy link
Contributor

@aireilly aireilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@aireilly
Copy link
Contributor

aireilly commented Jun 7, 2024

/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2024
@dfitzmau dfitzmau force-pushed the on-premise-accept-text-file branch from 68f9f5e to b1c31bf Compare June 7, 2024 14:13
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2024
Copy link

openshift-ci bot commented Jun 7, 2024

New changes are detected. LGTM label has been removed.

@ocpdocs-previewbot
Copy link

🤖 Fri Jun 07 14:25:03 - Prow CI generated the docs preview:

https://77082--ocpdocs-pr.netlify.app/

Copy link

openshift-ci bot commented Jun 7, 2024

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dfitzmau
Copy link
Contributor Author

dfitzmau commented Jun 7, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 7, 2024
@aldiazRH
Copy link
Contributor

aldiazRH commented Jun 7, 2024

/label peer-review-in-progress
/remove-label peer-review-needed

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 7, 2024
@aldiazRH
Copy link
Contributor

aldiazRH commented Jun 7, 2024

LGTM!

@aldiazRH
Copy link
Contributor

aldiazRH commented Jun 7, 2024

/label peer-review-done
/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jun 7, 2024
@dfitzmau
Copy link
Contributor Author

dfitzmau commented Jun 7, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 7, 2024
@skopacz1 skopacz1 added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jun 7, 2024
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge review LGTM, could you clarify which versions, if any other than main, this PR should be applied to?

@dfitzmau
Copy link
Contributor Author

dfitzmau commented Jun 7, 2024

@skopacz1 . Thanks for the comment. main only.

@skopacz1 skopacz1 merged commit 98a937f into openshift:main Jun 7, 2024
3 checks passed
@skopacz1 skopacz1 removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jun 7, 2024
@skopacz1 skopacz1 removed the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants