Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove etcd member update in recert cluster rename #56610

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Remove etcd member update in recert cluster rename #56610

merged 1 commit into from
Sep 18, 2024

Conversation

mresvanis
Copy link
Contributor

The etcd member update is now performed via recert rh-ecosystem-edge/recert#161.

@mresvanis
Copy link
Contributor Author

/hold

Until rh-ecosystem-edge/recert#161 is merged.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2024
@mresvanis
Copy link
Contributor Author

/cc @omertuc @tsorya

@omertuc
Copy link
Contributor

omertuc commented Sep 12, 2024

/lgtm

@omertuc
Copy link
Contributor

omertuc commented Sep 12, 2024

/approve

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 12, 2024
@mresvanis
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 16, 2024
@openshift-ci-robot
Copy link
Contributor

@mresvanis: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

4 similar comments
@openshift-ci-robot
Copy link
Contributor

@mresvanis: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@mresvanis: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@mresvanis: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@mresvanis: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mresvanis
Remove etcd member update in recert cluster rename
08d1560 
The etcd member update is now performed via recert.

Signed-off-by: Michail Resvanis <[email protected]>
@mresvanis mresvanis force-pushed the recert-remove-etcd-member-update branch from 6c57b5b to 08d1560 Compare September 18, 2024 06:38
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2024
@omertuc
Copy link
Contributor

omertuc commented Sep 18, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mresvanis, omertuc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@mresvanis: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-rh-ecosystem-edge-recert-main-baremetalds-sno-recert-cluster-rename rh-ecosystem-edge/recert presubmit Registry content changed
pull-ci-rh-ecosystem-edge-recert-release-4.16-baremetalds-sno-recert-cluster-rename rh-ecosystem-edge/recert presubmit Registry content changed
pull-ci-rh-ecosystem-edge-recert-release-4.15-baremetalds-sno-recert-cluster-rename rh-ecosystem-edge/recert presubmit Registry content changed
pull-ci-rh-ecosystem-edge-recert-release-4.14-baremetalds-sno-recert-cluster-rename rh-ecosystem-edge/recert presubmit Registry content changed
pull-ci-rh-ecosystem-edge-recert-v0-baremetalds-sno-recert-cluster-rename rh-ecosystem-edge/recert presubmit Registry content changed
periodic-ci-openshift-release-master-nightly-4.17-metal-ovn-single-node-recert-cluster-rename N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.18-metal-ovn-single-node-recert-cluster-rename N/A periodic Registry content changed
periodic-ci-rh-ecosystem-edge-recert-main-4.15-baremetalds-sno-recert-cluster-rename N/A periodic Registry content changed
periodic-ci-rh-ecosystem-edge-recert-main-4.14-baremetalds-sno-recert-cluster-rename N/A periodic Registry content changed
periodic-ci-rh-ecosystem-edge-recert-main-4.16-baremetalds-sno-recert-cluster-rename N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.16-metal-ovn-single-node-recert-cluster-rename N/A periodic Registry content changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot
Copy link
Contributor

@mresvanis: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mresvanis
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.17-metal-ovn-single-node-recert-cluster-rename

@openshift-ci-robot
Copy link
Contributor

@mresvanis: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mresvanis
Copy link
Contributor Author

/pj-rehearse ack

The ci/rehearse/periodic-ci-openshift-release-master-nightly-4.17-metal-ovn-single-node-recert-cluster-rename rehearsal failure is not relevant to this change.

@openshift-ci-robot
Copy link
Contributor

@mresvanis: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 18, 2024
@mresvanis
Copy link
Contributor Author

/override periodic-ci-openshift-release-master-nightly-4.17-metal-ovn-single-node-recert-cluster-rename

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 18, 2024

@mresvanis: mresvanis unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers.

In response to this:

/override periodic-ci-openshift-release-master-nightly-4.17-metal-ovn-single-node-recert-cluster-rename

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 18, 2024

@mresvanis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/check-cluster-profiles-config 6c57b5b link false /test check-cluster-profiles-config
ci/rehearse/rh-ecosystem-edge/recert/release-4.14/baremetalds-sno-recert-cluster-rename 6c57b5b link unknown /pj-rehearse pull-ci-rh-ecosystem-edge-recert-release-4.14-baremetalds-sno-recert-cluster-rename
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.17-metal-ovn-single-node-recert-cluster-rename 08d1560 link unknown /pj-rehearse periodic-ci-openshift-release-master-nightly-4.17-metal-ovn-single-node-recert-cluster-rename

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 61ebf1c into openshift:master Sep 18, 2024
15 of 16 checks passed
@mresvanis mresvanis deleted the recert-remove-etcd-member-update branch September 18, 2024 11:26
obochan-rh pushed a commit to obochan-rh/release that referenced this pull request Sep 24, 2024
@mresvanis @obochan-rh
Remove etcd member update in recert cluster rename (openshift#56610)
bfd93b6 
The etcd member update is now performed via recert.

Signed-off-by: Michail Resvanis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omertuc omertuc Awaiting requested review from omertuc

@tsorya tsorya Awaiting requested review from tsorya

@neisw neisw Awaiting requested review from neisw

@xueqzhan xueqzhan Awaiting requested review from xueqzhan

Assignees

@omertuc omertuc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mresvanis @omertuc @openshift-ci-robot