Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daostar metagov #519

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Rashmi-278
Copy link

@Rashmi-278 Rashmi-278 commented Oct 13, 2024

Context: DAOstar Retro Funding Application Contracts Submission

Copy link
Member

@ccerv1 ccerv1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the filename to "daostar-metagov.yaml" and name field to "daostar-metagov".

In order to prevent a collision with the metagov project, can you enumerate the specific github repos that should be associated with that projects. (Otherwise, we will have a collision because metagov owns the parent org for daostar, ie, metagov/daostar)

@ccerv1 ccerv1 added the pr:changes_suggested PR has been reviewed with changes suggested label Oct 14, 2024
@Rashmi-278
Copy link
Author

Can you change the filename to "daostar-metagov.yaml" and name field to "daostar-metagov".

In order to prevent a collision with the metagov project, can you enumerate the specific github repos that should be associated with that projects. (Otherwise, we will have a collision because metagov owns the parent org for daostar, ie, metagov/daostar)

Thank you for the suggestions Carl, I've updated the PR, please review

Copy link
Member

@ccerv1 ccerv1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per telegram chat:

  • the schema for the YAML is strictly enforced. you can check if your changes meet the schema from the CLI with pnpm validate
  • right now, the daostar-metagov entry will fail for for a couple reasons. first, we don't have any nesting for github artifacts. all we accept is a list of urls. second, some of the tags in your blockchain artifacts are not supported. here is the list of current tags (https://docs.opensource.observer/docs/contribute/project-data#supported-blockchain-networks-and-tags).
  • the other outstanding issue is that collision with the metagov entry that already exists. basically, our indexer assumes that anything that is contained with "github.com/metagov" belongs to metagov. So if it sees something like "github.com/metagov/daostar" then it will reject it (an artifact can only be claimed by one project). the best way to resolve this would be to enumerate any non-daostar github repos that should belong to metagov. alternatively, you keep everything in the metagov home.

websites:
- url: https://daostar.org
social:
twiiter:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

twitter

Copy link
Member

@ccerv1 ccerv1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry if I wasn't fully clear before. left comments inline 🙏

@@ -11,24 +11,6 @@ social:
github:
- url: https://github.com/metagov
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GitHub url(s) for metagov still need to be enumerated...
See my earlier comment:

the other outstanding issue is that collision with the metagov entry that already exists. basically, our indexer assumes that anything that is contained with "github.com/metagov" belongs to metagov. So if it sees something like "github.com/metagov/daostar" then it will reject it (an artifact can only be claimed by one project). the best way to resolve this would be to enumerate any non-daostar github repos that should belong to metagov. alternatively, you keep everything in the metagov home.

here are a list of repos that we've already indexed. I'm guessing not all of these are relevant active. (this includes the ones you've already linked to daostar, so you can ignore those)

dao-governance-surfaces
lodestarfi-members-uri
daochem-website
govbase-website
grant-innovation-lab
constitution-template
governing-many-worlds
gateway
snapshot-hub
agreements-prototype
govarch-website
govbase
safefordaos
to-community
gateway-sandbox
open-web-challenge
discord-research-bot
gateway-website
d20-governance
daostar-explorer-backend
agreementengine
constitution-data
attestation-list-api
daostar-api
kms-tools
example-driver
extitute
interop
validator
veephd
eip-4824-proposals-uri-template
metagov.org
eip4824
daostar-deprecated
eip-4824-members-uri-template
commons
governance-archaeology
eips
attestation-list
reputable-contracts
dada-sourcecred
daostar-explorer-frontend
aragon-daouri-api
daostar-labs
discourse-web-monetization
proposalsuri
ai-constitution
sourcecred-instance
daostar-documentation
daostar
dao-uri-data-indexing-backend
cryptopolitics-paper

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this from your PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:changes_suggested PR has been reviewed with changes suggested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants