Add version pinnning option #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `enable_openstack` class variable was left behind when the property of the same name was added. Since then a check for this condition has been added and it consequently leads to an error in the pep8 check. Signed-off-by: Frode Nordahl <[email protected]>
There are a couple of tests that make assertions on unsorted data which now break on Python 3.11. Signed-off-by: Frode Nordahl <[email protected]>
Signed-off-by: Frode Nordahl <[email protected]>
The OVN charms prepared for the upgrade from OVN 20.03 to newer versions by enabling the version pinning by default. Since then we have reached agreement with upstream that rolling upgrades should work when upgrading within the previous upstream LTS version and the next. Having the pinning enabled by default causes unnecessary grief for anyone already upgraded to OVN 22.03, so it's time to turn it off by default. We add a charm configuration option in case anyone wants to upgrade across LTS boundaries in the future. Closes-Bug: #2030944 Signed-off-by: Frode Nordahl <[email protected]>
mkalcok
reviewed
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review and merge commit by commit.