Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22.03] Make version pinning optional #86

Conversation

fnordahl
Copy link
Contributor

@fnordahl fnordahl commented Dec 4, 2023

Backport support for configuring version pinning. In order to not impose a change of behavior on existing deployments the default value for the option is set to 'true' on the stable branches.

Instrumented test run with these changes can be viewed in https://review.opendev.org/c/x/charm-ovn-chassis/+/902573

@fnordahl fnordahl changed the title Make version pinning optional [22.03] Make version pinning optional Dec 6, 2023
@fnordahl fnordahl marked this pull request as ready for review December 6, 2023 06:10
The OVN charms prepared for the upgrade from OVN 20.03 to newer
versions by unconditionally enabling version pinning.

Since then we have reached agreement with upstream that rolling
upgrades should work when upgrading within the previous upstream
LTS version and the next.

Having the pinning enabled may cause unnecessary grief for anyone
already upgraded to OVN 22.03.

Add a charm configuration option to allow controlling the version
pinning.

Closes-Bug: #2030944
Signed-off-by: Frode Nordahl <[email protected]>
(cherry picked from commit f68ecbd)
(cherry picked from commit 2a61104)

Conflicts:
	config.yaml
	unit_tests/test_lib_charms_ovn_charm.py
@fnordahl fnordahl force-pushed the branch-22.03-add-version-pinnning-option branch from 7396b8b to bde8c8c Compare December 6, 2023 06:15
@fnordahl fnordahl requested a review from mkalcok December 6, 2023 06:18
Copy link
Contributor

@mkalcok mkalcok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fnordahl fnordahl merged commit e07fce3 into openstack-charmers:stable/22.03 Dec 6, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants