[23.03] Make version pinning optional #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `enable_openstack` class variable was left behind when the property of the same name was added. Since then a check for this condition has been added and it consequently leads to an error in the pep8 check. Signed-off-by: Frode Nordahl <[email protected]> (cherry picked from commit 0cacfc1)
fnordahl
force-pushed
the
branch-23.03-add-version-pinnning-option
branch
from
2a61104
to
9c43523
Compare
fnordahl
changed the title
The OVN charms prepared for the upgrade from OVN 20.03 to newer versions by unconditionally enabling version pinning. Since then we have reached agreement with upstream that rolling upgrades should work when upgrading within the previous upstream LTS version and the next. Having the pinning enabled may cause unnecessary grief for anyone already upgraded to OVN 22.03. Add a charm configuration option to allow controlling the version pinning. Closes-Bug: #2030944 Signed-off-by: Frode Nordahl <[email protected]> (cherry picked from commit f68ecbd) Conflicts: config.yaml
fnordahl
force-pushed
the
branch-23.03-add-version-pinnning-option
branch
from
9c43523
to
0a35f73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport support for configuring version pinning. In order to not impose a change of behavior on existing deployments the default value for the option is set to 'true' on the stable branches.
Instrumented test run with these changes can be viewed in https://review.opendev.org/c/x/charm-ovn-chassis/+/902572 and https://review.opendev.org/c/x/charm-ovn-chassis/+/902571