[stable/22.03] Bail out configuring ovs if no OVNSDB available #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the ovsdb relation is departing the hook will fail since it will try to configure ovs while only partial information is available. Closes-Bug: #1944983
dosaboy
changed the title
brianphaley
reviewed
Oct 9, 2024
| else: | ||
| ch_core.hookenv.log('could not configure ovs due to unavailable ' | ||
| 'sbdb connection info - ovn-central relation ' | ||
| 'no longer available?', |
There was a problem hiding this comment.
Just have a nit on the message, should make it look like the one at the beginning of the function, something like:
'Could not configure Open vSwitch due to unavailable SBDB connection info - ovn-central relation no longer available?'
So what is the solution when this happens? Can we add more info to help get past it?
There was a problem hiding this comment.
Thats a fair point re the msg, could get that fixed on master. this is is really fixing the case where the application is being uninstalled e.g. when the node is being released to stop it raising an exception. Therefore it is not something that will need resolving.
javacruft
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the ovsdb relation is departing the hook will fail since it will try to configure ovs while only partial information is available.
Closes-Bug: #1944983