Continuation pr145 #164
Merged
Continuation pr145 #164
+30
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this PR wasn't rebased properly, given all the extra commits. Let me see if it can be cleaned up. |
abays
force-pushed
the
continuation_PR145
branch
from
b540d82
to
01bbb9f
Compare
|
@mauricioharley I think I've cleaned up the commits. Please look at the code changes to make sure I didn't undo anything. |
abays
force-pushed
the
continuation_PR145
branch
from
01bbb9f
to
a8e7054
Compare
abays
force-pushed
the
continuation_PR145
branch
from
a8e7054
to
eecd44d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, mauricioharley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 1c976d0
into
openstack-k8s-operators:main
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of PR #145. Barbican Keystone Listener and Barbican Worker were missed being fixed.