Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CustomServiceConfig barbican configuration #182

Merged

Conversation

Deydra71
Copy link
Contributor

This PR adds support for the CustomServiceConfig field in the Barbican CRD, allowing custom configurations for the Barbican API, worker, and keystone-listener services.

Example:

barbican:
  template:
    databaseInstance: openstack
    secret: osp-secret
    barbicanAPI:
      customServiceConfig: |
        [DEFAULT]
        max_allowed_secret_in_bytes = 1048576
      replicas: 1

The custom config file is now mounted as a 02-service-custom.conf file to /var/lib/config-data/default/ location and copied to /etc/barbican/barbican.conf.d/ as a custom.conf file.

Copy link
Contributor

@xek xek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

Copy link

openshift-ci bot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Deydra71, xek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b7a77ac into openstack-k8s-operators:main Nov 12, 2024
6 checks passed
@Deydra71
Copy link
Contributor Author

/cherry-pick 18.0-fr1

@openshift-cherrypick-robot

@Deydra71: new pull request created: #185

In response to this:

/cherry-pick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants