Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose new parameter expectedFailuresList #2513

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Expose new parameter expectedFailuresList #2513

wants to merge 3 commits into from
+3 −0

Conversation

kstrenkova
Copy link
Contributor

This change is needed for the introduction of new parameter expectedFailuresList to the test operator. The parameter will be used for ignoring results of specified tests that are expected to fail.

@kstrenkova
Expose new parameter expectedFailuresList
f40289d 
This change is needed for the introduction of new parameter
expectedFailuresList to the test operator. The parameter will be
used for ignoring results of specified tests that are expected to
fail.
@github-actions github-actions bot marked this pull request as draft November 4, 2024 12:58
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@lpiwowar lpiwowar mentioned this pull request Nov 4, 2024
Merged
kstrenkova added a commit to kstrenkova/test-operator that referenced this pull request Nov 7, 2024
@kstrenkova
Introduce new parameter Expected Failures List
356f40e 
The Expected Failures List parameter will help with specifying set
of tests whose failures we want to ignore. By adding test to this
list, its failure will not have impact on the jobs pass/fail. It
can help with not having to re-run long running jobs and save
time and resources in specific cases, for example when dealing
with flaky tests.

Depends-On: openstack-k8s-operators/ci-framework#2513
lpiwowar
lpiwowar requested changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@lpiwowar lpiwowar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me:) 👍 . Please, update the README.md so that it describes the newly added parameter.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 13, 2024

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lewisdenny for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kstrenkova
Expose new parameter expectedFailuresList
7752994 
This change is needed for the introduction of new parameter
expectedFailuresList to the test operator. The parameter will be
used for ignoring results of specified tests that are expected to
fail.
@kstrenkova
Copy link
Contributor Author

Looks good to me:) 👍 . Please, update the README.md so that it describes the newly added parameter.

I have added the changes to README.md 😄

@kstrenkova kstrenkova marked this pull request as ready for review November 13, 2024 12:57
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d94b06c4f2624fab84dbd39554e2ebdc

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 38m 58s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 16m 51s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 13m 41s
✔️ cifmw-multinode-tempest SUCCESS in 1h 52m 32s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 48s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 03s
✔️ build-push-container-cifmw-client SUCCESS in 37m 06s
✔️ cifmw-molecule-test_operator SUCCESS in 3m 13s

lpiwowar
lpiwowar approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@lpiwowar lpiwowar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you @kstrenkova 🎉

@lpiwowar lpiwowar requested a review from a team November 18, 2024 08:37
@lpiwowar
Copy link
Contributor

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8f27bfc62f3748d98f6247f3a9105e70

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 49m 13s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 16m 45s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 27m 20s
✔️ cifmw-multinode-tempest SUCCESS in 1h 38m 01s
✔️ noop SUCCESS in 0s
❌ cifmw-pod-ansible-test POST_FAILURE in 7m 23s
✔️ cifmw-pod-pre-commit SUCCESS in 6m 59s
✔️ build-push-container-cifmw-client SUCCESS in 21m 49s
✔️ cifmw-molecule-test_operator SUCCESS in 4m 02s

@lpiwowar
Copy link
Contributor

recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpiwowar lpiwowar lpiwowar approved these changes

Assignees
No one assigned
Labels
do-not-merge/contains-merge-commits Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kstrenkova @lpiwowar