Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BGP] ipv4routes can be defined for netconfig #2516

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[BGP] ipv4routes can be defined for netconfig #2516

wants to merge 1 commit into from

Conversation

eduolivares
Copy link
Contributor

In case of octavia, ipv4routes will be needed to connect to the management network.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign pablintino for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions github-actions bot marked this pull request as draft November 5, 2024 16:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

pablintino
pablintino reviewed Nov 5, 2024
View reviewed changes
roles/ci_gen_kustomize_values/templates/bgp_dt01/network-values/values.yaml.j2 Outdated
@@ -67,6 +67,13 @@ data:
- end: {{ range.end }}
start: {{ range.start }}
{% endfor %}
{% if network.tools.netconfig.ipv4_routes | default(false) %}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Netconfig has no routes options yet

ci-framework/plugins/module_utils/net_map/networking_env_definitions.py

Line 163 in e9e1037

class MappedNetconfigNetworkConfig:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pablintino, thanks for your comment.
I have updated the PR, although I'm not sure if the solution is so simple.

@eduolivares
[BGP] ipv4routes can be defined for netconfig
b75d8f6 
In case of octavia, ipv4routes will be needed to connect to the
management network.
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c1d8d98678cc4bceb0264a4bd90951a2

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 42m 54s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 14m 40s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 31m 18s
✔️ noop SUCCESS in 0s
❌ cifmw-pod-ansible-test FAILURE in 5m 08s
✔️ cifmw-pod-k8s-snippets-source SUCCESS in 4m 12s
✔️ cifmw-pod-pre-commit SUCCESS in 6m 55s
✔️ cifmw-architecture-validate-hci SUCCESS in 3m 45s
✔️ build-push-container-cifmw-client SUCCESS in 36m 58s
✔️ cifmw-molecule-ci_gen_kustomize_values SUCCESS in 4m 58s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablintino pablintino pablintino left review comments

Assignees
No one assigned
Labels
do-not-merge/work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eduolivares @pablintino