Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adoption osp deploy/uni01alpha #2548

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Adoption osp deploy/uni01alpha #2548

wants to merge 4 commits into from
+28 −14

Conversation

hjensas
Copy link
Contributor

@hjensas hjensas commented Nov 18, 2024

These changes are required for openstack-k8s-operators/data-plane-adoption#706 to deploy.

@hjensas
adoption_osp_deploy - Use dnf module
33e2314 
Switch to use the ansible.builtin.dnf in tasks/prepare_undercloud.yml -
facts are not always available and the `package` module then fails:
  "hostvars[''osp-undercloud-0'']" is undefined
@hjensas
Generate adoption_vars networks dynamically
b371129 
uni01alpha does not have the storagemgmt network, instead of hard-coding
the networks for `edpm_nodes` let's loop on node_nets.networks.keys()
@hjensas
Add support for networker nodes in adoption_vars.yaml.j2
2d4ddda 
uni01alpha uses networker nodes - add support to add these to the
adoption_vars.
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign viroel for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions GitHub Actions
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@github-actions github-actions bot marked this pull request as draft November 18, 2024 12:18
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/be7d016814664c78bac6362b5d1680e9

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 46m 14s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 16m 12s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 32m 24s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 28s
❌ cifmw-pod-pre-commit FAILURE in 7m 08s
✔️ build-push-container-cifmw-client SUCCESS in 36m 09s

@hjensas
Add adoption scenarion uni01alpha
b717693 
It is an empty patch, but it is required for the adoption_osp_deploy
role to run.
@hjensas hjensas force-pushed the adoption_osp_deploy/uni01alpha branch from 265ac65 to b717693 Compare November 18, 2024 15:52
@hjensas hjensas marked this pull request as ready for review November 19, 2024 08:36
cescgina
cescgina reviewed Nov 19, 2024
View reviewed changes
Copy link
Contributor

@cescgina cescgina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescgina cescgina cescgina left review comments

Assignees

@cescgina cescgina

Labels
lgtm Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hjensas @cescgina