-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pre-commit][kuttl]Check for multiple TestAsserts #386
base: main
Are you sure you want to change the base?
[pre-commit][kuttl]Check for multiple TestAsserts #386
Conversation
Add a new pre-commit check to avoid using more than one TestkAssert in a single kuttl assert file as that can lead to false positives as only the last TestAssert is run by kuttl. Fortunately there was no such issue in this repo.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gibizer The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test precommit-check
|
/test cinder-operator-build-deploy-tempest |
1 similar comment
/test cinder-operator-build-deploy-tempest |
@gibizer: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Tempest has failed twice in a row with the same error (but doesn't seem related to this change):
|
Add a new pre-commit check to avoid using more than one TestkAssert in a
single kuttl assert file as that can lead to false positives as only the
last TestAssert is run by kuttl.
Fortunately there was no such issue in this repo.