Ensure nodeSelector logic is consistent for all operators #466
Conversation
Switch to a pointer for nodeSelector to allow different logic for empty vs unset
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olliewalsh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold until the first PR has been reviewed openstack-k8s-operators/nova-operator#894 |
There is no need drop empty nodeSelector maps, omitempty already does this
| @@ -230,6 +231,14 @@ func GetCinderVolume(name types.NamespacedName) *cinderv1.CinderVolume { | |||
| return instance | |||
| } | |||
|
|
|||
| func GetCronJob(name types.NamespacedName) *batchv1.CronJob { | |||
There was a problem hiding this comment.
in a follow up should add this to https://github.com/openstack-k8s-operators/lib-common/tree/main/modules/common/test/functional
There was a problem hiding this comment.
yes, also for keystone where this came from
|
/test cinder-operator-build-deploy-tempest |
|
@olliewalsh: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
nodeSelectors are not currently applied consistently across all operators.
Some do not support nodeSelectors at all - will be implemented in this series of pull requests.
Some do not apply them to every pod (jobs/cronjobs esp) - will be resolved in this series of pull requests.
Some do not apply a node selector update correctly, only when not initially set.
Some support nodeSelectors but do not inherit the default nodeSelector from the OpenstackControlPlane CR.
Jira: OSPRH-10734