Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make apache timeout configurable #436

Merged

Conversation

karelyatin
Copy link
Contributor

@karelyatin karelyatin commented Oct 30, 2024

Added a parameter 'apiTimeout' to allow customization
to the Apache timeout.
The default is set to 120s which we do set for
HAProxy timeouts currently.

To be able to change the HAProxy value based on the apiTimeout with
any update (and not just the first time) the code adds a custom
annotation "api.neutron.openstack.org/timeout" with the value that was
initially set, this way flags it as being set by the neutron-operator.

There will be follow up patch in openstack-operator
to utilize the method 'SetDefaultRouteAnnotations' to set
these default route annotations.

Resolves: OSPRH-10843

Added a parameter 'apiTimeout' to allow customization
to the Apache timeout.
The default is set to 120s which we do set for
HAProxy timeouts currently.

To be able to change the HAProxy value based on the `apiTimeout` with
any update (and not just the first time) the code adds a custom
annotation "api.neutron.openstack.org/timeout" with the value that was
initially set, this way flags it as being set by the neutron-operator.

There will be follow up patch in openstack-operator
to utilize the method 'SetDefaultRouteAnnotations' to set
these default route annotations.

Resolves: OSPRH-10843
karelyatin added a commit to karelyatin/openstack-operator that referenced this pull request Nov 5, 2024
karelyatin added a commit to karelyatin/openstack-operator that referenced this pull request Nov 5, 2024
Copy link
Contributor

openshift-ci bot commented Nov 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karelyatin, slawqo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@averdagu
Copy link

averdagu commented Nov 6, 2024

Looks good to me! Thanks yatin

@fernandoroyosanchez
Copy link

Looks good to me, doing something similar here openstack-k8s-operators/octavia-operator#403

@openshift-merge-bot openshift-merge-bot bot merged commit 8108068 into openstack-k8s-operators:main Nov 6, 2024
6 checks passed
karelyatin added a commit to karelyatin/openstack-operator that referenced this pull request Nov 6, 2024
@karelyatin
Copy link
Contributor Author

/cherry-pick 18.0-fr1

@openshift-cherrypick-robot

@karelyatin: new pull request created: #438

In response to this:

/cherry-pick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants