-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make apache timeout configurable #436
Make apache timeout configurable #436
Conversation
Added a parameter 'apiTimeout' to allow customization to the Apache timeout. The default is set to 120s which we do set for HAProxy timeouts currently. To be able to change the HAProxy value based on the `apiTimeout` with any update (and not just the first time) the code adds a custom annotation "api.neutron.openstack.org/timeout" with the value that was initially set, this way flags it as being set by the neutron-operator. There will be follow up patch in openstack-operator to utilize the method 'SetDefaultRouteAnnotations' to set these default route annotations. Resolves: OSPRH-10843
cd469f1
to
ee86f21
Compare
Depends-On: openstack-k8s-operators/neutron-operator#436 Related-Issue: OSPRH-10843
Depends-On: openstack-k8s-operators/neutron-operator#436 Related-Issue: OSPRH-10843
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: karelyatin, slawqo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Looks good to me! Thanks yatin |
Looks good to me, doing something similar here openstack-k8s-operators/octavia-operator#403 |
8108068
into
openstack-k8s-operators:main
Depends-On: openstack-k8s-operators/neutron-operator#436 Related-Issue: OSPRH-10843
/cherry-pick 18.0-fr1 |
@karelyatin: new pull request created: #438 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Added a parameter 'apiTimeout' to allow customization
to the Apache timeout.
The default is set to 120s which we do set for
HAProxy timeouts currently.
To be able to change the HAProxy value based on the
apiTimeout
withany update (and not just the first time) the code adds a custom
annotation "api.neutron.openstack.org/timeout" with the value that was
initially set, this way flags it as being set by the neutron-operator.
There will be follow up patch in openstack-operator
to utilize the method 'SetDefaultRouteAnnotations' to set
these default route annotations.
Resolves: OSPRH-10843