Added a parameter 'apiTimeout' to allow customization #891
Conversation
Added a parameter 'apiTimeout' to allow customization to the Apache timeout. The default is set to 120s which we do set for HAProxy timeouts currently. To be able to change the HAProxy value based on the apiTimeout with any update (and not just the first time) the code adds a custom annotation "api.neutron.openstack.org/timeout" with the value that was initially set, this way flags it as being set by the nova-operator. Timeout is global for both api and metadata and they are set from nova lvl There will be follow up patch in openstack-operator to utilize the method 'SetDefaultRouteAnnotations' to set these default route annotations in openstack-operator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrkisaolamb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
im kind of -1 on this. we expclitly said we should not be adding tunabel like this for each config option to the CRDs i wonder is the there a way we can use DefaultConfigOverwrite or similar to allow a similar config override mechanism for apache does it support dropin files? if not we may need to do this but to me the is a code smell in the CRD. |
| @@ -57,6 +57,11 @@ spec: | |||
| description: APIDatabaseHostname - hostname to use when accessing | |||
| the API DB | |||
| type: string | |||
| apiTimeout: | |||
| default: 600 | |||
| description: APITimeout for Route and Apache | |||
There was a problem hiding this comment.
shouldnt the route timeout be condired by the existing service override?
There was a problem hiding this comment.
that is likely another timeout, or how would that help to have it shown up in templates/novametadata/config/httpd.conf ?
There was a problem hiding this comment.
however, we need to document that timouts set for APIs and haproxy configs in routes/ingress must match
| return | ||
| } | ||
|
|
||
| // Human operator modified the HAProxy timeout manually without removing the Heat flag |
Added a parameter 'apiTimeout' to allow customization to the Apache timeout.
The default is set to 120s which we do set for
HAProxy timeouts currently.
To be able to change the HAProxy value based on the apiTimeout with any update (and not just the first time) the code adds a custom annotation "api.neutron.openstack.org/timeout" with the value that was initially set, this way flags it as being set by the nova-operator.
Timeout is global for both api and metadata and they are set from nova lvl
There will be follow up patch in openstack-operator to utilize the method 'SetDefaultRouteAnnotations' to set these default route annotations in openstack-operator
Resolve: https://issues.redhat.com/browse/OSPRH-10955